Skip to content

Commit 52bd5c0

Browse files
committed
fix bloom info command update
didn't update tests, and got types wrong
1 parent bf8a93c commit 52bd5c0

File tree

5 files changed

+29
-49
lines changed

5 files changed

+29
-49
lines changed

packages/bloom/lib/commands/bloom/INFO.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ describe('BF.INFO', () => {
1717
]);
1818

1919
assert.equal(typeof reply, 'object');
20-
assert.equal(reply.capacity, 100);
21-
assert.equal(typeof reply.size, 'number');
22-
assert.equal(typeof reply.numberOfFilters, 'number');
23-
assert.equal(typeof reply.numberOfInsertedItems, 'number');
24-
assert.equal(typeof reply.expansionRate, 'number');
20+
assert.equal(reply['Capacity'], 100);
21+
assert.equal(typeof reply['Size'], 'number');
22+
assert.equal(typeof reply['Number of filters'], 'number');
23+
assert.equal(typeof reply['Number of items inserted'], 'number');
24+
assert.equal(typeof reply['Expansion rate'], 'number');
2525
}, GLOBAL.SERVERS.OPEN);
2626
});

packages/bloom/lib/commands/cuckoo/INFO.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ describe('CF.INFO', () => {
1717
]);
1818

1919
assert.equal(typeof reply, 'object');
20-
assert.equal(typeof reply.size, 'number');
21-
assert.equal(typeof reply.numberOfBuckets, 'number');
22-
assert.equal(typeof reply.numberOfFilters, 'number');
23-
assert.equal(typeof reply.numberOfInsertedItems, 'number');
24-
assert.equal(typeof reply.numberOfDeletedItems, 'number');
25-
assert.equal(typeof reply.bucketSize, 'number');
26-
assert.equal(typeof reply.expansionRate, 'number');
27-
assert.equal(typeof reply.maxIteration, 'number');
20+
assert.equal(typeof reply['Size'], 'number');
21+
assert.equal(typeof reply['Number of buckets'], 'number');
22+
assert.equal(typeof reply['Number of filters'], 'number');
23+
assert.equal(typeof reply['Number of items inserted'], 'number');
24+
assert.equal(typeof reply['Number of items deleted'], 'number');
25+
assert.equal(typeof reply['Bucket size'], 'number');
26+
assert.equal(typeof reply['Expansion rate'], 'number');
27+
assert.equal(typeof reply['Max iterations'], 'number');
2828
}, GLOBAL.SERVERS.OPEN);
2929
});

packages/bloom/lib/commands/cuckoo/INFO.ts

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,16 @@ export type CfInfoReplyMap = TuplesToMapReply<[
1212
[SimpleStringReply<'Max iterations'>, NumberReply]
1313
]>;
1414

15-
export interface CfInfoReply {
16-
size: NumberReply;
17-
numberOfBuckets: NumberReply;
18-
numberOfFilters: NumberReply;
19-
numberOfInsertedItems: NumberReply;
20-
numberOfDeletedItems: NumberReply;
21-
bucketSize: NumberReply;
22-
expansionRate: NumberReply;
23-
maxIteration: NumberReply;
24-
}
25-
2615
export default {
2716
FIRST_KEY_INDEX: 1,
2817
IS_READ_ONLY: true,
2918
transformArguments(key: RedisArgument) {
3019
return ['CF.INFO', key];
3120
},
3221
transformReply: {
33-
2: (reply: UnwrapReply<Resp2Reply<CfInfoReplyMap>>, _, typeMapping?: TypeMapping): CfInfoReply => {
34-
return transformInfoV2Reply<CfInfoReply>(reply, typeMapping);
22+
2: (reply: UnwrapReply<Resp2Reply<CfInfoReplyMap>>, _, typeMapping?: TypeMapping): CfInfoReplyMap => {
23+
return transformInfoV2Reply<CfInfoReplyMap>(reply, typeMapping);
3524
},
36-
3: undefined as unknown as () => CfInfoReply
25+
3: undefined as unknown as () => CfInfoReplyMap
3726
}
3827
} as const satisfies Command;

packages/bloom/lib/commands/t-digest/INFO.spec.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,15 @@ describe('TDIGEST.INFO', () => {
1616
client.tDigest.info('key')
1717
]);
1818

19-
assert(typeof reply.capacity, 'number');
20-
assert(typeof reply.mergedNodes, 'number');
21-
assert(typeof reply.unmergedNodes, 'number');
22-
assert(typeof reply.mergedWeight, 'number');
23-
assert(typeof reply.unmergedWeight, 'number');
24-
assert(typeof reply.totalCompression, 'number');
25-
assert(typeof reply.totalCompression, 'number');
19+
assert(typeof reply, 'object');
20+
assert(typeof reply['Compression'], 'number');
21+
assert(typeof reply['Capacity'], 'number');
22+
assert(typeof reply['Merged nodes'], 'number');
23+
assert(typeof reply['Unmerged nodes'], 'number');
24+
assert(typeof reply['Merged weight'], 'number');
25+
assert(typeof reply['Unmerged weight'], 'number');
26+
assert(typeof reply['Observations'], 'number');
27+
assert(typeof reply['Total compressions'], 'number');
28+
assert(typeof reply['Memory usage'], 'number');
2629
}, GLOBAL.SERVERS.OPEN);
2730
});

packages/bloom/lib/commands/t-digest/INFO.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,28 +13,16 @@ export type TdInfoReplyMap = TuplesToMapReply<[
1313
[SimpleStringReply<'Memory usage'>, NumberReply]
1414
]>;
1515

16-
export interface TdInfoReply {
17-
compression: NumberReply;
18-
capacity: NumberReply;
19-
mergedNodes: NumberReply;
20-
unmergedNodes: NumberReply;
21-
mergedWeight: NumberReply;
22-
unmergedWeight: NumberReply;
23-
observations: NumberReply,
24-
totalCompression: NumberReply;
25-
memoryUsage: NumberReply;
26-
}
27-
2816
export default {
2917
FIRST_KEY_INDEX: 1,
3018
IS_READ_ONLY: true,
3119
transformArguments(key: RedisArgument) {
3220
return ['TDIGEST.INFO', key];
3321
},
3422
transformReply: {
35-
2: (reply: UnwrapReply<Resp2Reply<TdInfoReplyMap>>, _, typeMapping?: TypeMapping): TdInfoReply => {
36-
return transformInfoV2Reply<TdInfoReply>(reply, typeMapping);
23+
2: (reply: UnwrapReply<Resp2Reply<TdInfoReplyMap>>, _, typeMapping?: TypeMapping): TdInfoReplyMap => {
24+
return transformInfoV2Reply<TdInfoReplyMap>(reply, typeMapping);
3725
},
38-
3: undefined as unknown as () => TdInfoReply
26+
3: undefined as unknown as () => TdInfoReplyMap
3927
}
4028
} as const satisfies Command;

0 commit comments

Comments
 (0)