Skip to content

Commit 5998413

Browse files
author
Ruben Bridgewater
committed
Update changelog and fix a test
1 parent 56861a8 commit 5998413

File tree

2 files changed

+15
-27
lines changed

2 files changed

+15
-27
lines changed

changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
Changelog
22
=========
33

4+
## v.2.4.2 - 27 Nov, 2015
5+
6+
Bugfixes
7+
8+
- Fixed not emitting ready after reconnect with disable_resubscribing ([@maxgalbu](https://github.com/maxgalbu))
9+
410
## v.2.4.1 - 25 Nov, 2015
511

612
Bugfixes

test/pubsub.spec.js

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -17,51 +17,32 @@ describe("publish/subscribe", function () {
1717
var message = "test message";
1818

1919
beforeEach(function (done) {
20-
var pubConnected;
21-
var subConnected;
20+
var end = helper.callFuncAfter(done, 2);
2221

2322
pub = redis.createClient.apply(redis.createClient, args);
2423
sub = redis.createClient.apply(redis.createClient, args);
2524
pub.once("connect", function () {
2625
pub.flushdb(function () {
27-
pubConnected = true;
28-
if (subConnected) {
29-
done();
30-
}
26+
end();
3127
});
3228
});
3329
sub.once("connect", function () {
34-
subConnected = true;
35-
if (pubConnected) {
36-
done();
37-
}
30+
end();
3831
});
3932
});
4033

4134
describe('disable resubscribe', function () {
4235
beforeEach(function (done) {
43-
var pubConnected;
44-
var subConnected;
45-
46-
pub = redis.createClient();
36+
sub.end(false);
4737
sub = redis.createClient({
4838
disable_resubscribing: true
4939
});
50-
pub.once("connect", function () {
51-
pubConnected = true;
52-
if (subConnected) {
53-
done();
54-
}
55-
});
5640
sub.once("connect", function () {
57-
subConnected = true;
58-
if (pubConnected) {
59-
done();
60-
}
41+
done();
6142
});
6243
});
6344

64-
it('does not fire subscribe events after reconnecting', function (done) {
45+
it.only('does not fire subscribe events after reconnecting', function (done) {
6546
var a = false;
6647
sub.on("subscribe", function (chnl, count) {
6748
if (chnl === channel2) {
@@ -75,11 +56,12 @@ describe("publish/subscribe", function () {
7556

7657
sub.on('reconnecting', function() {
7758
a = true;
59+
sub.on('ready', function () {
60+
setTimeout(done, 250);
61+
});
7862
});
7963

8064
sub.subscribe(channel, channel2);
81-
82-
setTimeout(done, 250);
8365
});
8466
});
8567

0 commit comments

Comments
 (0)