Skip to content

Commit 7327f5e

Browse files
committed
wip - changes of personal review
1 parent d896b09 commit 7327f5e

22 files changed

+123
-127
lines changed

packages/client/lib/commands/ACL_GETUSER.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
import { RedisArgument, TuplesToMapReply, BlobStringReply, ArrayReply, UnwrapReply, Resp2Reply, Command, SimpleStringReply } from '../RESP/types';
22

33
type AclUser = TuplesToMapReply<[
4-
[SimpleStringReply<'flags'>, ArrayReply<BlobStringReply>],
5-
[SimpleStringReply<'passwords'>, ArrayReply<BlobStringReply>],
6-
[SimpleStringReply<'commands'>, BlobStringReply],
4+
[BlobStringReply<'flags'>, ArrayReply<BlobStringReply>],
5+
[BlobStringReply<'passwords'>, ArrayReply<BlobStringReply>],
6+
[BlobStringReply<'commands'>, BlobStringReply],
77
/** changed to BlobStringReply in 7.0 */
8-
[SimpleStringReply<'keys'>, ArrayReply<BlobStringReply> | BlobStringReply],
8+
[BlobStringReply<'keys'>, ArrayReply<BlobStringReply> | BlobStringReply],
99
/** added in 6.2, changed to BlobStringReply in 7.0 */
10-
[SimpleStringReply<'channels'>, ArrayReply<BlobStringReply> | BlobStringReply],
10+
[BlobStringReply<'channels'>, ArrayReply<BlobStringReply> | BlobStringReply],
1111
/** added in 7.0 */
12-
[SimpleStringReply<'selectors'>, ArrayReply<TuplesToMapReply<[
13-
[SimpleStringReply<'commands'>, BlobStringReply],
14-
[SimpleStringReply<'keys'>, BlobStringReply],
15-
[SimpleStringReply<'channels'>, BlobStringReply]
12+
[BlobStringReply<'selectors'>, ArrayReply<TuplesToMapReply<[
13+
[BlobStringReply<'commands'>, BlobStringReply],
14+
[BlobStringReply<'keys'>, BlobStringReply],
15+
[BlobStringReply<'channels'>, BlobStringReply]
1616
]>>],
1717
]>;
1818

packages/client/lib/commands/ACL_LOG.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
import { ArrayReply, TuplesToMapReply, BlobStringReply, NumberReply, DoubleReply, UnwrapReply, Resp2Reply, Command, SimpleStringReply } from '../RESP/types';
22

33
export type AclLogReply = ArrayReply<TuplesToMapReply<[
4-
[SimpleStringReply<'count'>, NumberReply],
5-
[SimpleStringReply<'reason'>, BlobStringReply],
6-
[SimpleStringReply<'context'>, BlobStringReply],
7-
[SimpleStringReply<'object'>, BlobStringReply],
8-
[SimpleStringReply<'username'>, BlobStringReply],
9-
[SimpleStringReply<'age-seconds'>, DoubleReply],
10-
[SimpleStringReply<'client-info'>, BlobStringReply],
4+
[BlobStringReply<'count'>, NumberReply],
5+
[BlobStringReply<'reason'>, BlobStringReply],
6+
[BlobStringReply<'context'>, BlobStringReply],
7+
[BlobStringReply<'object'>, BlobStringReply],
8+
[BlobStringReply<'username'>, BlobStringReply],
9+
[BlobStringReply<'age-seconds'>, DoubleReply],
10+
[BlobStringReply<'client-info'>, BlobStringReply],
1111
/** added in 7.0 */
12-
[SimpleStringReply<'entry-id'>, NumberReply],
12+
[BlobStringReply<'entry-id'>, NumberReply],
1313
/** added in 7.0 */
14-
[SimpleStringReply<'timestamp-created'>, NumberReply],
14+
[BlobStringReply<'timestamp-created'>, NumberReply],
1515
/** added in 7.0 */
16-
[SimpleStringReply<'timestamp-last-updated'>, NumberReply]
16+
[BlobStringReply<'timestamp-last-updated'>, NumberReply]
1717
]>>;
1818

1919
export default {

packages/client/lib/commands/CLIENT_TRACKINGINFO.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { TuplesToMapReply, BlobStringReply, SetReply, NumberReply, ArrayReply, UnwrapReply, Resp2Reply, Command, SimpleStringReply } from '../RESP/types';
22

33
type TrackingInfo = TuplesToMapReply<[
4-
[SimpleStringReply<'flags'>, SetReply<BlobStringReply>],
5-
[SimpleStringReply<'redirect'>, NumberReply],
6-
[SimpleStringReply<'prefixes'>, ArrayReply<BlobStringReply>]
4+
[BlobStringReply<'flags'>, SetReply<BlobStringReply>],
5+
[BlobStringReply<'redirect'>, NumberReply],
6+
[BlobStringReply<'prefixes'>, ArrayReply<BlobStringReply>]
77
]>;
88

99
export default {

packages/client/lib/commands/CLUSTER_LINKS.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { ArrayReply, TuplesToMapReply, BlobStringReply, NumberReply, UnwrapReply, Resp2Reply, Command, SimpleStringReply } from '../RESP/types';
22

33
type ClusterLinksReply = ArrayReply<TuplesToMapReply<[
4-
[SimpleStringReply<'direction'>, BlobStringReply],
5-
[SimpleStringReply<'node'>, BlobStringReply],
6-
[SimpleStringReply<'create-time'>, NumberReply],
7-
[SimpleStringReply<'events'>, BlobStringReply],
8-
[SimpleStringReply<'send-buffer-allocated'>, NumberReply],
9-
[SimpleStringReply<'send-buffer-used'>, NumberReply],
4+
[BlobStringReply<'direction'>, BlobStringReply],
5+
[BlobStringReply<'node'>, BlobStringReply],
6+
[BlobStringReply<'create-time'>, NumberReply],
7+
[BlobStringReply<'events'>, BlobStringReply],
8+
[BlobStringReply<'send-buffer-allocated'>, NumberReply],
9+
[BlobStringReply<'send-buffer-used'>, NumberReply],
1010
]>>;
1111

1212
export default {

packages/client/lib/commands/FUNCTION_LIST.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ export interface FunctionListOptions {
55
}
66

77
export type FunctionListReplyItem = [
8-
[SimpleStringReply<'library_name'>, BlobStringReply | NullReply],
9-
[SimpleStringReply<'engine'>, BlobStringReply],
10-
[SimpleStringReply<'functions'>, ArrayReply<TuplesToMapReply<[
11-
[SimpleStringReply<'name'>, BlobStringReply],
12-
[SimpleStringReply<'description'>, BlobStringReply | NullReply],
13-
[SimpleStringReply<'flags'>, SetReply<BlobStringReply>],
8+
[BlobStringReply<'library_name'>, BlobStringReply | NullReply],
9+
[BlobStringReply<'engine'>, BlobStringReply],
10+
[BlobStringReply<'functions'>, ArrayReply<TuplesToMapReply<[
11+
[BlobStringReply<'name'>, BlobStringReply],
12+
[BlobStringReply<'description'>, BlobStringReply | NullReply],
13+
[BlobStringReply<'flags'>, SetReply<BlobStringReply>],
1414
]>>]
1515
];
1616

packages/client/lib/commands/FUNCTION_LIST_WITHCODE.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import FUNCTION_LIST, { FunctionListReplyItem } from './FUNCTION_LIST';
33

44
export type FunctionListWithCodeReply = ArrayReply<TuplesToMapReply<[
55
...FunctionListReplyItem,
6-
[SimpleStringReply<'library_code'>, BlobStringReply],
6+
[BlobStringReply<'library_code'>, BlobStringReply],
77
]>>;
88

99
export default {

packages/client/lib/commands/FUNCTION_STATS.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
import { Command, TuplesToMapReply, BlobStringReply, NullReply, NumberReply, MapReply, Resp2Reply, UnwrapReply, SimpleStringReply } from '../RESP/types';
1+
import { Command, TuplesToMapReply, BlobStringReply, NullReply, NumberReply, MapReply, Resp2Reply, UnwrapReply } from '../RESP/types';
22
import { isNullReply } from './generic-transformers';
33

44
type RunningScript = NullReply | TuplesToMapReply<[
5-
[SimpleStringReply<'name'>, BlobStringReply],
6-
[SimpleStringReply<'command'>, BlobStringReply],
7-
[SimpleStringReply<'duration_ms'>, NumberReply]
5+
[BlobStringReply<'name'>, BlobStringReply],
6+
[BlobStringReply<'command'>, BlobStringReply],
7+
[BlobStringReply<'duration_ms'>, NumberReply]
88
]>;
99

1010
type Engine = TuplesToMapReply<[
11-
[SimpleStringReply<'libraries_count'>, NumberReply],
12-
[SimpleStringReply<'functions_count'>, NumberReply]
11+
[BlobStringReply<'libraries_count'>, NumberReply],
12+
[BlobStringReply<'functions_count'>, NumberReply]
1313
]>;
1414

1515
type Engines = MapReply<BlobStringReply, Engine>;
1616

1717
type FunctionStatsReply = TuplesToMapReply<[
18-
[SimpleStringReply<'running_script'>, RunningScript],
19-
[SimpleStringReply<'engines'>, Engines]
18+
[BlobStringReply<'running_script'>, RunningScript],
19+
[BlobStringReply<'engines'>, Engines]
2020
]>;
2121

2222
export default {

packages/client/lib/commands/HELLO.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RedisArgument, RespVersions, TuplesToMapReply, BlobStringReply, NumberReply, ArrayReply, UnwrapReply, Resp2Reply, Command, SimpleStringReply } from '../RESP/types';
1+
import { RedisArgument, RespVersions, TuplesToMapReply, BlobStringReply, NumberReply, ArrayReply, UnwrapReply, Resp2Reply, Command } from '../RESP/types';
22

33
export interface HelloOptions {
44
protover?: RespVersions;
@@ -10,13 +10,13 @@ export interface HelloOptions {
1010
}
1111

1212
export type HelloReply = TuplesToMapReply<[
13-
[SimpleStringReply<'server'>, BlobStringReply],
14-
[SimpleStringReply<'version'>, BlobStringReply],
15-
[SimpleStringReply<'proto'>, NumberReply<RespVersions>],
16-
[SimpleStringReply<'id'>, NumberReply],
17-
[SimpleStringReply<'mode'>, BlobStringReply],
18-
[SimpleStringReply<'role'>, BlobStringReply],
19-
[SimpleStringReply<'modules'>, ArrayReply<BlobStringReply>]
13+
[BlobStringReply<'server'>, BlobStringReply],
14+
[BlobStringReply<'version'>, BlobStringReply],
15+
[BlobStringReply<'proto'>, NumberReply<RespVersions>],
16+
[BlobStringReply<'id'>, NumberReply],
17+
[BlobStringReply<'mode'>, BlobStringReply],
18+
[BlobStringReply<'role'>, BlobStringReply],
19+
[BlobStringReply<'modules'>, ArrayReply<BlobStringReply>]
2020
]>;
2121

2222
export default {

packages/client/lib/commands/LCS_IDX.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RedisArgument, TuplesToMapReply, ArrayReply, NumberReply, UnwrapReply, Resp2Reply, Command, TuplesReply, SimpleStringReply } from '../RESP/types';
1+
import { RedisArgument, TuplesToMapReply, ArrayReply, NumberReply, UnwrapReply, Resp2Reply, Command, TuplesReply, BlobStringReply } from '../RESP/types';
22
import LCS from './LCS';
33

44
export interface LcsIdxOptions {
@@ -18,8 +18,8 @@ export type LcsIdxMatches = ArrayReply<
1818
>;
1919

2020
export type LcsIdxReply = TuplesToMapReply<[
21-
[SimpleStringReply<'matches'>, LcsIdxMatches],
22-
[SimpleStringReply<'len'>, NumberReply]
21+
[BlobStringReply<'matches'>, LcsIdxMatches],
22+
[BlobStringReply<'len'>, NumberReply]
2323
]>;
2424

2525
export default {

packages/client/lib/commands/LCS_IDX_WITHMATCHLEN.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RedisArgument, TuplesToMapReply, ArrayReply, TuplesReply, NumberReply, UnwrapReply, Resp2Reply, Command, SimpleStringReply } from '../RESP/types';
1+
import { RedisArgument, TuplesToMapReply, ArrayReply, TuplesReply, NumberReply, UnwrapReply, Resp2Reply, Command, BlobStringReply } from '../RESP/types';
22
import LCS_IDX, { LcsIdxOptions, LcsIdxRange } from './LCS_IDX';
33

44
export type LcsIdxWithMatchLenMatches = ArrayReply<
@@ -10,8 +10,8 @@ export type LcsIdxWithMatchLenMatches = ArrayReply<
1010
>;
1111

1212
export type LcsIdxWithMatchLenReply = TuplesToMapReply<[
13-
[SimpleStringReply<'matches'>, LcsIdxWithMatchLenMatches],
14-
[SimpleStringReply<'len'>, NumberReply]
13+
[BlobStringReply<'matches'>, LcsIdxWithMatchLenMatches],
14+
[BlobStringReply<'len'>, NumberReply]
1515
]>;
1616

1717
export default {

0 commit comments

Comments
 (0)