Skip to content

Commit be450c1

Browse files
committed
fix(doctests): update dt-set.js and dt-ss.js for v5 compliance
- Updated boolean return values to numbers for SISMEMBER and SMISMEMBER commands - Fixed client lifecycle to use client.close() instead of client.quit() - Removed unnecessary await from createClient() - Added order-independent assertions for set operations - Removed debug statement
1 parent 5141a50 commit be450c1

File tree

2 files changed

+13
-15
lines changed

2 files changed

+13
-15
lines changed

doctests/dt-set.js

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import assert from 'assert';
44
import { createClient } from 'redis';
55

6-
const client = await createClient();
6+
const client = createClient();
77
await client.connect();
88
// HIDE_END
99
// REMOVE_START
@@ -38,15 +38,15 @@ await client.sAdd('bikes:racing:france', 'bike:1', 'bike:2', 'bike:3')
3838
await client.sAdd('bikes:racing:usa', 'bike:1', 'bike:4')
3939
// HIDE_END
4040
const res5 = await client.sIsMember('bikes:racing:usa', 'bike:1')
41-
console.log(res5) // >>> true
41+
console.log(res5) // >>> 1
4242

4343
const res6 = await client.sIsMember('bikes:racing:usa', 'bike:2')
44-
console.log(res6) // >>> false
44+
console.log(res6) // >>> 0
4545
// STEP_END
4646

4747
// REMOVE_START
48-
assert.equal(res5, true)
49-
assert.equal(res6, false)
48+
assert.equal(res5, 1)
49+
assert.equal(res6, 0)
5050
// REMOVE_END
5151

5252
// STEP_START sinster
@@ -93,15 +93,15 @@ assert.deepEqual(res10.sort(), ['bike:1', 'bike:2', 'bike:3'])
9393

9494
// STEP_START smIsMember
9595
const res11 = await client.sIsMember('bikes:racing:france', 'bike:1')
96-
console.log(res11) // >>> true
96+
console.log(res11) // >>> 1
9797

9898
const res12 = await client.smIsMember('bikes:racing:france', ['bike:2', 'bike:3', 'bike:4'])
99-
console.log(res12) // >>> [true, true, false]
99+
console.log(res12) // >>> [1, 1, 0]
100100
// STEP_END
101101

102102
// REMOVE_START
103-
assert.equal(res11, true)
104-
assert.deepEqual(res12, [true, true, false])
103+
assert.equal(res11, 1)
104+
assert.deepEqual(res12, [1, 1, 0])
105105
// REMOVE_END
106106

107107
// STEP_START sDiff
@@ -112,7 +112,7 @@ console.log(res13) // >>> [ 'bike:2', 'bike:3' ]
112112
// STEP_END
113113

114114
// REMOVE_START
115-
assert.deepEqual(res13, ['bike:2', 'bike:3'])
115+
assert.deepEqual(res13.sort(), ['bike:2', 'bike:3'].sort())
116116
await client.del('bikes:racing:france')
117117
await client.del('bikes:racing:usa')
118118
// REMOVE_END
@@ -147,14 +147,12 @@ assert.deepEqual(res14, ['bike:1'])
147147
assert.deepEqual(res15.sort(), ['bike:1', 'bike:2', 'bike:3', 'bike:4'])
148148
assert.deepEqual(res16, [])
149149
assert.deepEqual(res17, ['bike:4'])
150-
assert.deepEqual(res18, ['bike:2', 'bike:3'])
150+
assert.deepEqual(res18.sort(), ['bike:2', 'bike:3'].sort())
151151
await client.del('bikes:racing:france')
152152
await client.del('bikes:racing:usa')
153153
await client.del('bikes:racing:italy')
154154
// REMOVE_END
155155

156-
debugger;
157-
158156
// STEP_START sRem
159157
await client.sAdd('bikes:racing:france', ['bike:1', 'bike:2', 'bike:3', 'bike:4', 'bike:5'])
160158

@@ -173,6 +171,6 @@ console.log(res22) // >>> bike:4 or other random value
173171

174172
// REMOVE_START
175173
assert.equal(res19, 1)
176-
client.quit()
174+
await client.close()
177175
// none of the other results are deterministic
178176
// REMOVE_END

doctests/dt-ss.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,5 +158,5 @@ assert.equal(res17, 1)
158158
assert.equal(res18, 0)
159159
assert.equal(res19, 150.0)
160160
assert.equal(res20, 200.0)
161-
await client.quit();
161+
await client.close();
162162
// REMOVE_END

0 commit comments

Comments
 (0)