improve the vadd api

Author: nkaradzhov

packages/client/lib/commands/VADD.spec.ts

@@ -5,26 +5,43 @@ import { parseArgs } from './generic-transformers';
 
 describe('VADD', () => {
   describe('transformArguments', () => {
-    it('with VALUES', () => {
+    it('basic usage', () => {
       assert.deepEqual(
         parseArgs(VADD, 'key', [1.0, 2.0, 3.0], 'element'),
         ['VADD', 'key', 'VALUES', '3', '1', '2', '3', 'element']
       );
     });
 
-    it('with FP32', () => {
+    it('with REDUCE option', () => {
       assert.deepEqual(
-        parseArgs(VADD, 'key', Buffer.from([0x3f, 0x80, 0x00, 0x00]), 'element'),
-        ['VADD', 'key', 'FP32', Buffer.from([0x3f, 0x80, 0x00, 0x00]), 'element']
+        parseArgs(VADD, 'key', [1.0, 2.0], 'element', { REDUCE: 50 }),
+        ['VADD', 'key', 'REDUCE', '50', 'VALUES', '2', '1', '2', 'element']
       );
     });
 
-    it('with options', () => {
+    it('with quantization options', () => {
+      assert.deepEqual(
+        parseArgs(VADD, 'key', [1.0, 2.0], 'element', { QUANT: 'Q8' }),
+        ['VADD', 'key', 'VALUES', '2', '1', '2', 'element', 'Q8']
+      );
+
+      assert.deepEqual(
+        parseArgs(VADD, 'key', [1.0, 2.0], 'element', { QUANT: 'BIN' }),
+        ['VADD', 'key', 'VALUES', '2', '1', '2', 'element', 'BIN']
+      );
+
+      assert.deepEqual(
+        parseArgs(VADD, 'key', [1.0, 2.0], 'element', { QUANT: 'NOQUANT' }),
+        ['VADD', 'key', 'VALUES', '2', '1', '2', 'element', 'NOQUANT']
+      );
+    });
+
+    it('with all options', () => {
       assert.deepEqual(
         parseArgs(VADD, 'key', [1.0, 2.0], 'element', {
           REDUCE: 50,
           CAS: true,
-          Q8: true,
+          QUANT: 'Q8',
           EF: 200,
           SETATTR: { name: 'test', value: 42 },
           M: 16

packages/client/lib/commands/VADD.ts

@@ -5,9 +5,7 @@ import { transformDoubleArgument } from './generic-transformers';
 export interface VAddOptions {
   REDUCE?: number;
   CAS?: boolean;
-  NOQUANT?: boolean;
-  Q8?: boolean;
-  BIN?: boolean;
+  QUANT?: 'NOQUANT' | 'BIN' | 'Q8',
   EF?: number;
   SETATTR?: Record<string, any>;
   M?: number;
@@ -19,15 +17,15 @@ export default {
    * 
    * @param parser - The command parser
    * @param key - The name of the key that will hold the vector set data
-   * @param vector - The vector data as FP32 blob or array of numbers
+   * @param vector - The vector data as array of numbers
    * @param element - The name of the element being added to the vector set
    * @param options - Optional parameters for vector addition
    * @see https://redis.io/commands/vadd/
    */
   parseCommand(
     parser: CommandParser,
     key: RedisArgument,
-    vector: RedisArgument | Array<number>,
+    vector: Array<number>,
     element: RedisArgument,
     options?: VAddOptions
   ) {
@@ -38,13 +36,9 @@ export default {
       parser.push('REDUCE', options.REDUCE.toString());
     }
 
-    if (Array.isArray(vector)) {
-      parser.push('VALUES', vector.length.toString());
-      for (const value of vector) {
-        parser.push(transformDoubleArgument(value));
-      }
-    } else {
-      parser.push('FP32', vector);
+    parser.push('VALUES', vector.length.toString());
+    for (const value of vector) {
+      parser.push(transformDoubleArgument(value));
     }
 
     parser.push(element);
@@ -53,13 +47,7 @@ export default {
       parser.push('CAS');
     }
 
-    if (options?.NOQUANT) {
-      parser.push('NOQUANT');
-    } else if (options?.Q8) {
-      parser.push('Q8');
-    } else if (options?.BIN) {
-      parser.push('BIN');
-    }
+    options?.QUANT && parser.push(options.QUANT);
 
     if (options?.EF !== undefined) {
       parser.push('EF', options.EF.toString());