Skip to content

Commit f500398

Browse files
author
Ruben Bridgewater
committed
Run tests only with the js parser instead of hiredis and js parser from now on
This removes the optional-dev-dependency as this is not needed from now on anymore
1 parent 0dc45bd commit f500398

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"coverage": "nyc report --reporter=html",
2222
"benchmark": "node benchmarks/multi_bench.js",
2323
"test": "nyc --cache mocha ./test/*.js ./test/commands/*.js --timeout=8000",
24-
"pretest": "optional-dev-dependency hiredis",
2524
"posttest": "eslint . --fix"
2625
},
2726
"dependencies": {
@@ -40,7 +39,6 @@
4039
"metrics": "^0.1.9",
4140
"mocha": "^2.3.2",
4241
"nyc": "^6.0.0",
43-
"optional-dev-dependency": "^1.1.0",
4442
"tcp-port-used": "^0.1.2",
4543
"uuid": "^2.0.1",
4644
"win-spawn": "^2.0.0"

test/helper.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,11 @@ module.exports = {
163163
}
164164
var parsers = ['javascript'];
165165
var protocols = ['IPv4'];
166-
try {
167-
require('hiredis');
168-
parsers.push('hiredis');
169-
} catch (e) {/* ignore eslint */}
166+
// The js parser works the same as the hiredis parser, just activate this if you want to be on the safe side
167+
// try {
168+
// require('hiredis');
169+
// parsers.push('hiredis');
170+
// } catch (e) {/* ignore eslint */}
170171
if (process.platform !== 'win32') {
171172
protocols.push('IPv6', '/tmp/redis.sock');
172173
}

0 commit comments

Comments
 (0)