Fix and add more tests

Ruben Bridgewater · Ruben Bridgewater · commit f543d45d1f0d · 2015-09-19T17:48:25.000+02:00
diff --git a/test/commands/blpop.spec.js b/test/commands/blpop.spec.js
@@ -15,7 +15,6 @@ describe("The 'blpop' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/client.spec.js b/test/commands/client.spec.js
@@ -15,7 +15,6 @@ describe("The 'client' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/dbsize.spec.js b/test/commands/dbsize.spec.js
@@ -23,7 +23,6 @@ describe("The 'dbsize' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -45,7 +44,6 @@ describe("The 'dbsize' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.flushdb(function (err, res) {
                             helper.isString("OK")(err, res);
diff --git a/test/commands/del.spec.js b/test/commands/del.spec.js
@@ -13,7 +13,6 @@ describe("The 'del' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/eval.spec.js b/test/commands/eval.spec.js
@@ -16,7 +16,6 @@ describe("The 'eval' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/exits.spec.js b/test/commands/exits.spec.js
@@ -13,7 +13,6 @@ describe("The 'exits' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/expire.spec.js b/test/commands/expire.spec.js
@@ -13,7 +13,6 @@ describe("The 'expire' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/flushdb.spec.js b/test/commands/flushdb.spec.js
@@ -23,7 +23,6 @@ describe("The 'flushdb' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -45,7 +44,6 @@ describe("The 'flushdb' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         done();
                     });
diff --git a/test/commands/get.spec.js b/test/commands/get.spec.js
@@ -23,7 +23,6 @@ describe("The 'get' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -45,7 +44,6 @@ describe("The 'get' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         done();
                     });
diff --git a/test/commands/getset.spec.js b/test/commands/getset.spec.js
@@ -24,7 +24,6 @@ describe("The 'getset' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -47,7 +46,6 @@ describe("The 'getset' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         done();
                     });
diff --git a/test/commands/hgetall.spec.js b/test/commands/hgetall.spec.js
@@ -16,7 +16,6 @@ describe("The 'hgetall' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.flushdb(done);
                     });
@@ -58,7 +57,6 @@ describe("The 'hgetall' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.flushdb(done);
                     });
diff --git a/test/commands/hincrby.spec.js b/test/commands/hincrby.spec.js
@@ -14,7 +14,6 @@ describe("The 'hincrby' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/hlen.spec.js b/test/commands/hlen.spec.js
@@ -13,7 +13,6 @@ describe("The 'hlen' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/hmset.spec.js b/test/commands/hmset.spec.js
@@ -15,7 +15,6 @@ describe("The 'hmset' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/hset.spec.js b/test/commands/hset.spec.js
@@ -15,7 +15,6 @@ describe("The 'hset' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/incr.spec.js b/test/commands/incr.spec.js
@@ -17,7 +17,6 @@ describe("The 'incr' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.set(key, "9007199254740992", function (err, res) {
                             helper.isNotError()(err, res);
diff --git a/test/commands/keys.spec.js b/test/commands/keys.spec.js
@@ -15,7 +15,6 @@ describe("The 'keys' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/mset.spec.js b/test/commands/mset.spec.js
@@ -25,7 +25,6 @@ describe("The 'mset' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -47,7 +46,6 @@ describe("The 'mset' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         done();
                     });
diff --git a/test/commands/msetnx.spec.js b/test/commands/msetnx.spec.js
@@ -13,7 +13,6 @@ describe("The 'msetnx' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/multi.spec.js b/test/commands/multi.spec.js
@@ -23,7 +23,6 @@ describe("The 'multi' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -46,7 +45,6 @@ describe("The 'multi' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.flushdb(function (err) {
                             return done(err);
@@ -298,6 +296,17 @@ describe("The 'multi' method", function () {
                     });
                 });
 
+                it("should work without any callback", function (done) {
+                    helper.serverVersionAtLeast.call(this, client, [2, 6, 5]);
+
+                    var multi = client.multi();
+                    multi.set("baz", "binary");
+                    multi.set("foo", "bar");
+                    multi.exec();
+
+                    client.get('foo', helper.isString('bar', done));
+                });
+
             });
         });
     });
diff --git a/test/commands/randomkey.test.js b/test/commands/randomkey.test.js
@@ -14,7 +14,6 @@ describe("The 'randomkey' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/rename.spec.js b/test/commands/rename.spec.js
@@ -13,7 +13,6 @@ describe("The 'rename' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/renamenx.spec.js b/test/commands/renamenx.spec.js
@@ -13,7 +13,6 @@ describe("The 'renamenx' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/rpush.spec.js b/test/commands/rpush.spec.js
@@ -14,7 +14,6 @@ describe("The 'rpush' command", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/sadd.spec.js b/test/commands/sadd.spec.js
@@ -14,7 +14,6 @@ describe("The 'sadd' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/scard.spec.js b/test/commands/scard.spec.js
@@ -13,7 +13,6 @@ describe("The 'scard' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/script.spec.js b/test/commands/script.spec.js
@@ -17,7 +17,6 @@ describe("The 'script' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/sdiff.spec.js b/test/commands/sdiff.spec.js
@@ -14,7 +14,6 @@ describe("The 'sdiff' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/sdiffstore.spec.js b/test/commands/sdiffstore.spec.js
@@ -14,7 +14,6 @@ describe("The 'sdiffstore' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/select.spec.js b/test/commands/select.spec.js
@@ -15,7 +15,6 @@ describe("The 'select' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -37,7 +36,6 @@ describe("The 'select' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () { done(); });
                 });
 
diff --git a/test/commands/set.spec.js b/test/commands/set.spec.js
@@ -23,7 +23,6 @@ describe("The 'set' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         client.quit();
                     });
@@ -45,7 +44,6 @@ describe("The 'set' method", function () {
 
                 beforeEach(function (done) {
                     client = redis.createClient.apply(redis.createClient, args);
-                    client.once("error", done);
                     client.once("connect", function () {
                         done();
                     });
diff --git a/test/commands/setex.spec.js b/test/commands/setex.spec.js
@@ -14,7 +14,6 @@ describe("The 'setex' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/setnx.spec.js b/test/commands/setnx.spec.js
@@ -13,7 +13,6 @@ describe("The 'setnx' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/sinter.spec.js b/test/commands/sinter.spec.js
@@ -14,7 +14,6 @@ describe("The 'sinter' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/sinterstore.spec.js b/test/commands/sinterstore.spec.js
@@ -14,7 +14,6 @@ describe("The 'sinterstore' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/sismember.spec.js b/test/commands/sismember.spec.js
@@ -13,7 +13,6 @@ describe("The 'sismember' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/slowlog.spec.js b/test/commands/slowlog.spec.js
@@ -14,7 +14,6 @@ describe("The 'slowlog' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/smembers.spec.js b/test/commands/smembers.spec.js
@@ -14,7 +14,6 @@ describe("The 'smembers' method", function () {
 
             beforeEach(function (done) {
                 client = redis.createClient.apply(redis.createClient, args);
-                client.once("error", done);
                 client.once("connect", function () {
                     client.flushdb(done);
                 });
diff --git a/test/commands/smove.spec.js b/test/commands/smove.spec.js
diff --git a/test/commands/spop.spec.js b/test/commands/spop.spec.js
diff --git a/test/commands/srem.spec.js b/test/commands/srem.spec.js
diff --git a/test/commands/sunion.spec.js b/test/commands/sunion.spec.js
diff --git a/test/commands/sunionstore.spec.js b/test/commands/sunionstore.spec.js
diff --git a/test/commands/ttl.spec.js b/test/commands/ttl.spec.js
diff --git a/test/commands/type.spec.js b/test/commands/type.spec.js
diff --git a/test/commands/watch.spec.js b/test/commands/watch.spec.js
diff --git a/test/node_redis.spec.js b/test/node_redis.spec.js
