Skip to content

Commit f8fa887

Browse files
committed
fix some more
1 parent cf5510f commit f8fa887

File tree

5 files changed

+22
-16
lines changed

5 files changed

+22
-16
lines changed

docs/v4-to-v5.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,13 @@ Some command arguments/replies have changed to align more closely to data types
109109
- `GEORADIUSBYMEMBERSTORE` -> `GEORADIUSBYMEMBER_STORE`
110110
- `XACK`: `boolean` -> `number` [^boolean-to-number]
111111
- `XADD`: the `INCR` option has been removed, use `XADD_INCR` instead
112+
- `LASTSAVE`: `Date` -> `number` (unix timestamp)
113+
- `HELLO`: `protover` moved from the options object to it's own argument, `auth` -> `AUTH`, `clientName` -> `SETNAME`
114+
- `MODULE LIST`: `version` -> `ver` [^map-keys]
115+
- `MEMORY STATS`: [^map-keys]
112116

113117
[^enum-to-constants]: TODO
114118

115119
[^boolean-to-number]: TODO
120+
121+
[^map-keys]: [TODO](https://github.com/redis/node-redis/discussions/2506)

packages/client/lib/commands/COPY.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe('COPY', () => {
4545
testUtils.testAll('copy', async client => {
4646
assert.equal(
4747
await client.copy('{tag}source', '{tag}destination'),
48-
false
48+
0
4949
);
5050
}, {
5151
client: GLOBAL.SERVERS.OPEN,
Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
import { strict as assert } from 'assert';
22
import testUtils, { GLOBAL } from '../test-utils';
3-
import { transformArguments } from './DBSIZE';
3+
import DBSIZE from './DBSIZE';
44

55
describe('DBSIZE', () => {
6-
it('transformArguments', () => {
7-
assert.deepEqual(
8-
transformArguments(),
9-
['DBSIZE']
10-
);
11-
});
6+
it('transformArguments', () => {
7+
assert.deepEqual(
8+
DBSIZE.transformArguments(),
9+
['DBSIZE']
10+
);
11+
});
1212

13-
testUtils.testWithClient('client.dbSize', async client => {
14-
assert.equal(
15-
await client.dbSize(),
16-
0
17-
);
18-
}, GLOBAL.SERVERS.OPEN);
13+
testUtils.testWithClient('client.dbSize', async client => {
14+
assert.equal(
15+
await client.dbSize(),
16+
0
17+
);
18+
}, GLOBAL.SERVERS.OPEN);
1919
});

packages/client/lib/commands/EXPIRE.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe('EXPIRE', () => {
2222
testUtils.testAll('expire', async client => {
2323
assert.equal(
2424
await client.expire('key', 0),
25-
false
25+
0
2626
);
2727
}, {
2828
client: GLOBAL.SERVERS.OPEN,

packages/client/lib/commands/EXPIREAT.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ describe('EXPIREAT', () => {
3030
testUtils.testAll('expireAt', async client => {
3131
assert.equal(
3232
await client.expireAt('key', 1),
33-
false
33+
0
3434
);
3535
}, {
3636
client: GLOBAL.SERVERS.OPEN,

0 commit comments

Comments
 (0)