Skip to content

Commit fbdac9e

Browse files
committed
tests: remove hiredis from testing suite
as parser no longer supports hiredis
1 parent c78e55d commit fbdac9e

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

test/helper.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,6 @@ module.exports = {
163163
}
164164
var parsers = ['javascript'];
165165
var protocols = ['IPv4'];
166-
// The js parser works the same as the hiredis parser, just activate this if you want to be on the safe side
167-
// try {
168-
// require('hiredis');
169-
// parsers.push('hiredis');
170-
// } catch (e) {/* ignore eslint */}
171166
if (process.platform !== 'win32') {
172167
protocols.push('IPv6', '/tmp/redis.sock');
173168
}

test/pubsub.spec.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -515,19 +515,15 @@ describe('publish/subscribe', function () {
515515
sub.stream.once('data', function () {
516516
assert.strictEqual(sub.message_buffers, false);
517517
assert.strictEqual(sub.shouldBuffer, false);
518-
sub.on('pmessageBuffer', function (pattern, channel, message) {
519-
if (parser !== 'javascript' && typeof pattern === 'string') {
518+
sub.on('pmessageBuffer', function (pattern, channel) {
519+
if (typeof pattern === 'string') {
520520
pattern = new Buffer(pattern);
521521
channel = new Buffer(channel);
522522
}
523523
assert.strictEqual(pattern.inspect(), new Buffer('*').inspect());
524524
assert.strictEqual(channel.inspect(), new Buffer('/foo').inspect());
525525
sub.quit(end);
526526
});
527-
if (parser === 'javascript') {
528-
assert.notStrictEqual(sub.message_buffers, sub.buffers);
529-
}
530-
531527
});
532528
var batch = sub.batch();
533529
batch.psubscribe('*');

0 commit comments

Comments
 (0)