Skip to content

Commit 5177da0

Browse files
Ensuring git hash on PR comment is string
1 parent 55515c3 commit 5177da0

File tree

1 file changed

+4
-0
lines changed
  • redis_benchmarks_specification/__common__

1 file changed

+4
-0
lines changed

redis_benchmarks_specification/__common__/github.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ def generate_build_started_pr_comment(
2121
)
2222
comment_body += f"Started building at {build_datetime}\n"
2323
comment_body += "You can check each build/benchmark progress in grafana:\n"
24+
if not isinstance(git_hash, str):
25+
git_hash = git_hash.decode()
2426
comment_body += f" - git hash: {git_hash}\n"
2527
comment_body += f" - git branch: {git_branch}\n"
2628
comment_body += f" - commit date and time: {commit_datetime}\n"
@@ -57,6 +59,8 @@ def generate_build_finished_pr_comment(
5759
)
5860
comment_body += f"Started building at {build_start_datetime} and took {build_duration_seconds} seconds.\n"
5961
comment_body += "You can check each build/benchmark progress in grafana:\n"
62+
if not isinstance(git_hash, str):
63+
git_hash = git_hash.decode()
6064
comment_body += f" - git hash: {git_hash}\n"
6165
comment_body += f" - git branch: {git_branch}\n"
6266
comment_body += f" - commit date and time: {commit_datetime}\n"

0 commit comments

Comments
 (0)