Skip to content

Commit cbd3172

Browse files
Fixed scc memtier benchmarks
1 parent 321714e commit cbd3172

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

utils/tests/test_self_contained_coordinator_memtier.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ def test_self_contained_coordinator_blocking_read():
105105
assert number_processed_streams == 1
106106
test_name = "memtier_benchmark-1Mkeys-100B-expire-use-case"
107107
tf_triggering_env = "ci"
108+
tf_github_org = "redis"
109+
tf_github_repo = "redis"
108110
deployment_name = "oss-standalone"
109111
deployment_type = "oss-standalone"
110112
use_metric_context_path = False
@@ -711,7 +713,7 @@ def test_self_contained_coordinator_dockerhub_valkey():
711713
assert result == True
712714
assert number_processed_streams == 1
713715
assert num_process_test_suites == 1
714-
by_version_key = f"ci.benchmarks.redislabs/ci/{github_org}/{github_repo}/memtier_benchmark-1Mkeys-load-string-with-10B-values/by.version/{redis_version}/benchmark_end/oss-standalone/memory_maxmemory"
716+
by_version_key = f"ci.benchmarks.redis/ci/{github_org}/{github_repo}/memtier_benchmark-1Mkeys-load-string-with-10B-values/by.version/{redis_version}/benchmark_end/oss-standalone/memory_maxmemory"
715717
assert datasink_conn.exists(by_version_key)
716718
rts = datasink_conn.ts()
717719
# check we have by version metrics
@@ -844,7 +846,7 @@ def test_dockerhub_via_cli():
844846
assert result == True
845847
assert number_processed_streams == 1
846848
assert num_process_test_suites == 1
847-
by_version_key = f"ci.benchmarks.redislabs/ci/{github_org}/{github_repo}/memtier_benchmark-1Mkeys-load-string-with-10B-values/by.version/{redis_version}/benchmark_end/oss-standalone/memory_maxmemory"
849+
by_version_key = f"ci.benchmarks.redis/ci/{github_org}/{github_repo}/memtier_benchmark-1Mkeys-load-string-with-10B-values/by.version/{redis_version}/benchmark_end/oss-standalone/memory_maxmemory"
848850
assert datasink_conn.exists(by_version_key)
849851
rts = datasink_conn.ts()
850852
# check we have by version metrics
@@ -973,11 +975,13 @@ def test_dockerhub_via_cli_airgap():
973975
assert result == True
974976
assert number_processed_streams == 1
975977
assert num_process_test_suites == 1
976-
by_version_key = f"ci.benchmarks.redislabs/ci/{github_org}/{github_repo}/memtier_benchmark-1Mkeys-load-string-with-10B-values/by.version/{redis_version}/benchmark_end/oss-standalone/memory_maxmemory"
978+
by_version_key = f"ci.benchmarks.redis/ci/{github_org}/{github_repo}/memtier_benchmark-1Mkeys-load-string-with-10B-values/by.version/{redis_version}/benchmark_end/oss-standalone/memory_maxmemory"
977979
assert datasink_conn.exists(by_version_key)
978980
rts = datasink_conn.ts()
979981
# check we have by version metrics
980-
assert "version" in rts.info(by_version_key).labels
982+
key_labels = rts.info(by_version_key).labels
983+
logging.info(key_labels)
984+
assert "version" in key_labels
981985
assert redis_version == rts.info(by_version_key).labels["version"]
982986

983987
# get all keys
@@ -1077,7 +1081,7 @@ def test_prepare_memtier_benchmark_parameters():
10771081
)
10781082
assert (
10791083
benchmark_command_str
1080-
== 'memtier_benchmark --json-out-file 1.json --port 12000 --server localhost "--data-size" "100" --command "SETEX __key__ 10 __data__" --command-key-pattern="R" --command "SET __key__ __data__" --command-key-pattern="R" --command "GET __key__" --command-key-pattern="R" --command "DEL __key__" --command-key-pattern="R" -c 50 -t 2 --hide-histogram --test-time 300'
1084+
== 'memtier_benchmark --json-out-file 1.json --port 12000 --server localhost "--data-size" "100" --command "SETEX __key__ 10 __data__" --command-key-pattern="R" --command "SET __key__ __data__" --command-key-pattern="R" --command "GET __key__" --command-key-pattern="R" --command "DEL __key__" --command-key-pattern="R" -c 50 -t 2 --hide-histogram --test-time 120 --key-minimum 1 --key-maximum 1000000'
10811085
)
10821086
oss_api_enabled = True
10831087
(
@@ -1093,7 +1097,7 @@ def test_prepare_memtier_benchmark_parameters():
10931097
)
10941098
assert (
10951099
benchmark_command_str
1096-
== 'memtier_benchmark --json-out-file 1.json --port 12000 --server localhost --cluster-mode "--data-size" "100" --command "SETEX __key__ 10 __data__" --command-key-pattern="R" --command "SET __key__ __data__" --command-key-pattern="R" --command "GET __key__" --command-key-pattern="R" --command "DEL __key__" --command-key-pattern="R" -c 50 -t 2 --hide-histogram --test-time 300'
1100+
== 'memtier_benchmark --json-out-file 1.json --port 12000 --server localhost --cluster-mode "--data-size" "100" --command "SETEX __key__ 10 __data__" --command-key-pattern="R" --command "SET __key__ __data__" --command-key-pattern="R" --command "GET __key__" --command-key-pattern="R" --command "DEL __key__" --command-key-pattern="R" -c 50 -t 2 --hide-histogram --test-time 120 --key-minimum 1 --key-maximum 1000000'
10971101
)
10981102

10991103

0 commit comments

Comments
 (0)