try/catch on metric exporting and redis shutdown on coordinator. fixed memtier_benchmark-1Mkeys-string-get-2MB test given it required 2tb of memory

Author: fcostaoliveira

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redis-benchmarks-specification"
-version = "0.1.89"
+version = "0.1.90"
 description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
 authors = ["filipecosta90 <[email protected]>","Redis Performance Group <[email protected]>"]
 readme = "Readme.md"

redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py

@@ -1011,31 +1011,46 @@ def process_self_contained_coordinator_stream(
                                     )
 
                                 dataset_load_duration_seconds = 0
+                                try:
+                                    exporter_datasink_common(
+                                        benchmark_config,
+                                        benchmark_duration_seconds,
+                                        build_variant_name,
+                                        datapoint_time_ms,
+                                        dataset_load_duration_seconds,
+                                        datasink_conn,
+                                        datasink_push_results_redistimeseries,
+                                        git_branch,
+                                        git_version,
+                                        metadata,
+                                        redis_conns,
+                                        results_dict,
+                                        running_platform,
+                                        setup_name,
+                                        setup_type,
+                                        test_name,
+                                        tf_github_org,
+                                        tf_github_repo,
+                                        tf_triggering_env,
+                                        topology_spec_name,
+                                        default_metrics,
+                                    )
+                                    r.shutdown(save=False)
+
+                                except redis.exceptions.ConnectionError as e:
+                                    logging.critical(
+                                        "Some unexpected exception was caught during metric fetching. Skipping it..."
+                                    )
+                                    logging.critical(
+                                        f"Exception type: {type(e).__name__}"
+                                    )
+                                    logging.critical(f"Exception message: {str(e)}")
+                                    logging.critical("Traceback details:")
+                                    logging.critical(traceback.format_exc())
+                                    print("-" * 60)
+                                    traceback.print_exc(file=sys.stdout)
+                                    print("-" * 60)
 
-                                exporter_datasink_common(
-                                    benchmark_config,
-                                    benchmark_duration_seconds,
-                                    build_variant_name,
-                                    datapoint_time_ms,
-                                    dataset_load_duration_seconds,
-                                    datasink_conn,
-                                    datasink_push_results_redistimeseries,
-                                    git_branch,
-                                    git_version,
-                                    metadata,
-                                    redis_conns,
-                                    results_dict,
-                                    running_platform,
-                                    setup_name,
-                                    setup_type,
-                                    test_name,
-                                    tf_github_org,
-                                    tf_github_repo,
-                                    tf_triggering_env,
-                                    topology_spec_name,
-                                    default_metrics,
-                                )
-                                r.shutdown(save=False)
                                 test_result = True
                                 total_test_suite_runs = total_test_suite_runs + 1
 
@@ -1054,10 +1069,20 @@ def process_self_contained_coordinator_stream(
                                     logging.critical("Printing redis container log....")
 
                                     print("-" * 60)
-
-                                    print(
-                                        redis_container.logs(stdout=True, stderr=True)
-                                    )
+                                    try:
+                                        print(
+                                            redis_container.logs(
+                                                stdout=True, stderr=True
+                                            )
+                                        )
+                                    except docker.errors.NotFound:
+                                        logging.info(
+                                            "When trying to stop DB container with id {} and image {} it was already stopped".format(
+                                                redis_container.id,
+                                                redis_container.image,
+                                            )
+                                        )
+                                    pass
 
                                     print("-" * 60)
 

redis_benchmarks_specification/test-suites/memtier_benchmark-1Mkeys-string-get-2MB.yml

@@ -9,7 +9,7 @@ dbconfig:
   preload_tool:
     run_image: redislabs/memtier_benchmark:edge
     tool: memtier_benchmark
-    arguments: '"--data-size" "2000000" "--ratio" "1:0" "--key-pattern" "P:P" "-c" "50" "-t" "2" "--hide-histogram" "--key-minimum" "1"'
+    arguments: '"--data-size" "2000000" "--ratio" "1:0" "--key-pattern" "P:P" "-c" "50" "-t" "2" "--hide-histogram" "--key-minimum" "1" "--key-minimum" "1000"'
   resources:
     requests:
       memory: 2g
@@ -22,7 +22,7 @@ build-variants:
 clientconfig:
   run_image: redislabs/memtier_benchmark:edge
   tool: memtier_benchmark
-  arguments: --data-size 2000000  --ratio 0:1 --key-pattern R:R -c 25 -t 4 --hide-histogram --test-time 180
+  arguments: --data-size 2000000 --key-minimum 1 --key-maximum 1000 --ratio 0:1 --key-pattern R:R -c 25 -t 4 --hide-histogram --test-time 180
   resources:
     requests:
       cpus: '4'