benchmark runner is now properly pushing updates to github PR on every test progress

Author: fcostaoliveira

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "redis-benchmarks-specification"
-version = "0.1.80"
+version = "0.1.87"
 description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
 authors = ["filipecosta90 <[email protected]>","Redis Performance Group <[email protected]>"]
 readme = "Readme.md"

redis_benchmarks_specification/__api__/app.py

@@ -163,7 +163,7 @@ def base():
                     "gh_org": gh_org,
                 }
                 if pull_request_number is not None:
-                    fields_after["pull_request_number"] = pull_request_number
+                    fields_after["pull_request"] = pull_request_number
                 app.logger.info(
                     "Using event {} to trigger benchmark. final fields: {}".format(
                         event_type, fields_after

redis_benchmarks_specification/__common__/github.py

@@ -32,7 +32,8 @@ def generate_build_finished_pr_comment(
     comment_body += f"       - test name regex: {tests_regexp}\n"
     comment_body += f"       - command group regex: {tests_groups_regexp}\n\n"
     for benchmark_stream_id in benchmark_stream_ids:
-        benchmark_stream_id = benchmark_stream_id.decode()
+        if not isinstance(benchmark_stream_id, str):
+            benchmark_stream_id = benchmark_stream_id.decode()
         grafana_benchmark_status_link = f"https://benchmarksredisio.grafana.net/d/edsxdsrbexhc0f/ce-benchmark-run-status?orgId=1&var-benchmark_work_stream={benchmark_stream_id}"
         print("=============================================================")
         print(f"Check benchmark run status in: {grafana_benchmark_status_link}")
@@ -176,7 +177,7 @@ def markdown_progress_bar(current, total, bar_length=40):
 
 
 def generate_benchmark_started_pr_comment(
-    benchmark_stream_ids,
+    benchmark_stream_id,
     total_pending,
     total_benchmarks,
 ):
@@ -189,14 +190,14 @@ def generate_benchmark_started_pr_comment(
 
     completed = total_benchmarks - total_pending
     comment_body += (
-        f"Status: {markdown_progress_bar(completed,total_benchmarks)} pending.\n\n"
+        f"Status: {markdown_progress_bar(completed,total_benchmarks,80)} completed.\n\n"
     )
     comment_body += f"In total will run {total_benchmarks} benchmarks.\n"
     comment_body += f"    - {total_pending} pending.\n"
-    comment_body += f"    - {total_pending} completed.\n"
+    comment_body += f"    - {completed} completed.\n"
 
-    for benchmark_stream_id in benchmark_stream_ids:
+    if not isinstance(benchmark_stream_id, str):
         benchmark_stream_id = benchmark_stream_id.decode()
-        grafana_benchmark_status_link = f"https://benchmarksredisio.grafana.net/d/edsxdsrbexhc0f/ce-benchmark-run-status?orgId=1&var-benchmark_work_stream={benchmark_stream_id}"
-        comment_body += f"You can check a the status in detail via the [grafana link]({grafana_benchmark_status_link})"
+    grafana_benchmark_status_link = f"https://benchmarksredisio.grafana.net/d/edsxdsrbexhc0f/ce-benchmark-run-status?orgId=1&var-benchmark_work_stream={benchmark_stream_id}"
+    comment_body += f"You can check a the status in detail via the [grafana link]({grafana_benchmark_status_link})"
     return comment_body

redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py

@@ -1039,22 +1039,28 @@ def process_self_contained_coordinator_stream(
                                 test_result = True
                                 total_test_suite_runs = total_test_suite_runs + 1
 
-                            except:
+                            except Exception as e:
                                 logging.critical(
-                                    "Some unexpected exception was caught "
-                                    "during local work. Failing test...."
+                                    "Some unexpected exception was caught during local work. Failing test...."
                                 )
-                                logging.critical(sys.exc_info()[0])
+                                logging.critical(f"Exception type: {type(e).__name__}")
+                                logging.critical(f"Exception message: {str(e)}")
+                                logging.critical("Traceback details:")
+                                logging.critical(traceback.format_exc())
                                 print("-" * 60)
                                 traceback.print_exc(file=sys.stdout)
                                 print("-" * 60)
                                 if redis_container is not None:
                                     logging.critical("Printing redis container log....")
+
                                     print("-" * 60)
+
                                     print(
                                         redis_container.logs(stdout=True, stderr=True)
                                     )
+
                                     print("-" * 60)
+
                                 test_result = False
                             # tear-down
                             logging.info("Tearing down setup")
@@ -1116,12 +1122,16 @@ def process_self_contained_coordinator_stream(
                     )
         else:
             logging.error("Missing commit information within received message.")
-    except:
+
+    except Exception as e:
         logging.critical(
             "Some unexpected exception was caught "
             "during local work on stream {}. Failing test....".format(stream_id)
         )
-        logging.critical(sys.exc_info()[0])
+        logging.critical(f"Exception type: {type(e).__name__}")
+        logging.critical(f"Exception message: {str(e)}")
+        logging.critical("Traceback details:")
+        logging.critical(traceback.format_exc())
         print("-" * 60)
         traceback.print_exc(file=sys.stdout)
         print("-" * 60)