Skip to content

Commit 6d009a0

Browse files
author
Simon Prickett
committed
Fixed linter errors, refactored delete.
1 parent 885b24b commit 6d009a0

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

aredis_om/model/model.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,8 +1114,10 @@ def key(self):
11141114
pk = getattr(self, self._meta.primary_key.field.name)
11151115
return self.make_primary_key(pk)
11161116

1117-
async def delete(self):
1118-
return await self.db().delete(self.key())
1117+
@classmethod
1118+
async def delete(cls, pk: Any) -> int:
1119+
"""Delete data at this key."""
1120+
return await cls.db().delete(cls.make_primary_key(pk))
11191121

11201122
@classmethod
11211123
async def get(cls, pk: Any) -> "RedisModel":
@@ -1335,10 +1337,6 @@ async def get(cls, pk: Any) -> "HashModel":
13351337
result = cls.parse_obj(document)
13361338
return result
13371339

1338-
@classmethod
1339-
async def delete(cls, pk: Any) -> int:
1340-
return await cls.db().delete(cls.make_primary_key(pk))
1341-
13421340
@classmethod
13431341
@no_type_check
13441342
def _get_value(cls, *args, **kwargs) -> Any:
@@ -1507,10 +1505,6 @@ async def get(cls, pk: Any) -> "JsonModel":
15071505
raise NotFoundError
15081506
return cls.parse_raw(document)
15091507

1510-
@classmethod
1511-
async def delete(cls, pk: Any) -> int:
1512-
return await cls.db().delete(cls.make_primary_key(pk))
1513-
15141508
@classmethod
15151509
def redisearch_schema(cls):
15161510
key_prefix = cls.make_key(cls._meta.primary_key_pattern.format(pk=""))

tests/test_hash_model.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,7 @@ async def test_saves_model_and_creates_pk(m):
374374
member2 = await m.Member.get(member.pk)
375375
assert member2 == member
376376

377+
377378
@pytest.mark.asyncio
378379
async def test_delete(m):
379380
member = m.Member(
@@ -382,7 +383,7 @@ async def test_delete(m):
382383
383384
join_date=today,
384385
age=97,
385-
bio="This is a test use to be deleted.",
386+
bio="This is a test user to be deleted.",
386387
)
387388

388389
await member.save()

tests/test_json_model.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ async def test_saves_model_and_creates_pk(address, m, redis):
186186
assert member2 == member
187187
assert member2.address == address
188188

189+
189190
@pytest.mark.asyncio
190191
async def test_delete(address, m, redis):
191192
member = m.Member(

0 commit comments

Comments
 (0)