Skip to content

Commit 249daac

Browse files
committed
fix: remove @Autowired in favor of constructor injection (resolved gh-133)
1 parent 4a84f30 commit 249daac

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

redis-om-spring/src/main/java/com/redis/om/spring/RedisJSONKeyValueAdapter.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import org.apache.commons.logging.LogFactory;
1515
import org.springframework.beans.PropertyAccessor;
1616
import org.springframework.beans.PropertyAccessorFactory;
17-
import org.springframework.beans.factory.annotation.Autowired;
1817
import org.springframework.data.annotation.CreatedDate;
1918
import org.springframework.data.annotation.LastModifiedDate;
2019
import org.springframework.data.redis.core.RedisCallback;
@@ -29,6 +28,7 @@
2928
import org.springframework.util.StringUtils;
3029

3130
import com.google.gson.Gson;
31+
import com.google.gson.GsonBuilder;
3232
import com.redis.om.spring.convert.RedisOMCustomConversions;
3333
import com.redis.om.spring.ops.RedisModulesOperations;
3434
import com.redis.om.spring.ops.json.JSONOperations;
@@ -48,8 +48,6 @@ public class RedisJSONKeyValueAdapter extends RedisKeyValueAdapter {
4848
private @Nullable String keyspaceNotificationsConfigParameter = null;
4949
private RedisModulesOperations<String> modulesOperations;
5050
private RediSearchIndexer indexer;
51-
52-
@Autowired
5351
private Gson gson;
5452

5553
/**
@@ -63,13 +61,14 @@ public class RedisJSONKeyValueAdapter extends RedisKeyValueAdapter {
6361
*/
6462
@SuppressWarnings("unchecked")
6563
public RedisJSONKeyValueAdapter(RedisOperations<?, ?> redisOps, RedisModulesOperations<?> rmo,
66-
RedisMappingContext mappingContext, RediSearchIndexer keyspaceToIndexMap) {
64+
RedisMappingContext mappingContext, RediSearchIndexer keyspaceToIndexMap, GsonBuilder gsonBuilder) {
6765
super(redisOps, mappingContext, new RedisOMCustomConversions());
6866
this.modulesOperations = (RedisModulesOperations<String>) rmo;
6967
this.redisJSONOperations = modulesOperations.opsForJSON();
7068
this.redisOperations = redisOps;
7169
this.mappingContext = mappingContext;
7270
this.indexer = keyspaceToIndexMap;
71+
this.gson = gsonBuilder.create();
7372
}
7473

7574
/*

redis-om-spring/src/main/java/com/redis/om/spring/RedisModulesConfiguration.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,16 +120,18 @@ public RediSearchIndexer redisearchIndexer(ApplicationContext ac) {
120120
@Bean(name = "redisJSONKeyValueAdapter")
121121
RedisJSONKeyValueAdapter getRedisJSONKeyValueAdapter(RedisOperations<?, ?> redisOps,
122122
RedisModulesOperations<?> redisModulesOperations, RedisMappingContext mappingContext,
123-
RediSearchIndexer keyspaceToIndexMap) {
124-
return new RedisJSONKeyValueAdapter(redisOps, redisModulesOperations, mappingContext, keyspaceToIndexMap);
123+
RediSearchIndexer keyspaceToIndexMap,
124+
GsonBuilder gsonBuilder) {
125+
return new RedisJSONKeyValueAdapter(redisOps, redisModulesOperations, mappingContext, keyspaceToIndexMap, gsonBuilder);
125126
}
126127

127128
@Bean(name = "redisJSONKeyValueTemplate")
128129
public CustomRedisKeyValueTemplate getRedisJSONKeyValueTemplate(RedisOperations<?, ?> redisOps,
129130
RedisModulesOperations<?> redisModulesOperations, RedisMappingContext mappingContext,
130-
RediSearchIndexer keyspaceToIndexMap) {
131+
RediSearchIndexer keyspaceToIndexMap,
132+
GsonBuilder gsonBuilder) {
131133
return new CustomRedisKeyValueTemplate(
132-
getRedisJSONKeyValueAdapter(redisOps, redisModulesOperations, mappingContext, keyspaceToIndexMap),
134+
getRedisJSONKeyValueAdapter(redisOps, redisModulesOperations, mappingContext, keyspaceToIndexMap, gsonBuilder),
133135
mappingContext);
134136
}
135137

0 commit comments

Comments
 (0)