fix connect_to_address

Author: agnesnatasya

redis/asyncio/sentinel.py

@@ -92,6 +92,14 @@ async def connect_to_same_address(self):
             lambda error: asyncio.sleep(0),
         )
 
+    async def connect_to_address(self, address):
+        """
+        Similar to connect, but instead of rotating to the next slave (if not in master mode),
+        it just connects to the same address of the connection object.
+        """
+        self.host, self.port = address
+        return await self.connect_to_same_address()
+
     async def read_response(
         self,
         disable_decoding: bool = False,
@@ -280,8 +288,8 @@ async def get_connection(
             # connect to the previous replica.
             # This will connect to the host and port of the replica
             else:
-                await connection.connect_to_same_address()
-            self.ensure_connection_connected_to_address(connection)
+                await connection.connect_to_address((server_host, server_port))
+            await self.ensure_connection_connected_to_address(connection)
         except BaseException:
             # Release the connection back to the pool so that we don't
             # leak it

redis/sentinel.py

@@ -74,6 +74,14 @@ def connect_to_same_address(self):
             lambda error: None
         )
 
+    def connect_to_address(self, address):
+        """
+        Similar to connect, but instead of rotating to the next slave (if not in master mode),
+        it just connects to the address supplied.
+        """
+        self.host, self.port = address
+        return self.connect_to_same_address()
+
     def can_read_same_address(self, timeout=0):
         """Similar to can_read_same_address, but calls connect_to_same_address instead of connect"""
         sock = self._sock
@@ -312,7 +320,7 @@ def get_connection(
             # connect to the previous replica.
             # This will connect to the host and port of the replica
             else:
-                connection.connect_to_same_address()
+                connection.connect_to_address((server_host, server_port))
             self.ensure_connection_connected_to_address(connection)
         except BaseException:
             # Release the connection back to the pool so that we don't

tests/test_asyncio/test_connection_pool.py

@@ -94,6 +94,8 @@ class DummyConnection(Connection):
 
     def __init__(self, **kwargs):
         self.kwargs = kwargs
+        self.host = kwargs.get("host", None)
+        self.port = kwargs.get("port", None)
 
     def repr_pieces(self):
         return [("id", id(self)), ("kwargs", self.kwargs)]

tests/test_connection_pool.py

@@ -20,6 +20,8 @@ class DummyConnection:
     def __init__(self, **kwargs):
         self.kwargs = kwargs
         self.pid = os.getpid()
+        self.host = kwargs.get("host", None)
+        self.port = kwargs.get("port", None)
 
     def connect(self):
         pass