Skip to content

Commit 2d52d45

Browse files
committed
Fixing credential tests and linters errors
1 parent 093813a commit 2d52d45

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

tests/test_credentials.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@
1111
from redis import AuthenticationError, DataError, Redis, ResponseError
1212
from redis.auth.err import RequestTokenErr
1313
from redis.backoff import NoBackoff
14-
from redis.connection import ConnectionInterface, ConnectionPool
14+
from redis.connection import (
15+
ConnectionInterface,
16+
ConnectionPool,
17+
)
1518
from redis.credentials import CredentialProvider, UsernamePasswordCredentialProvider
1619
from redis.exceptions import ConnectionError, RedisError
1720
from redis.retry import Retry
@@ -428,6 +431,8 @@ def re_auth_callback(token):
428431
def test_re_auth_pub_sub_in_resp3(self, credential_provider):
429432
mock_pubsub_connection = Mock(spec=ConnectionInterface)
430433
mock_pubsub_connection.get_protocol.return_value = 3
434+
435+
mock_pubsub_connection.should_reconnect = Mock(return_value=False)
431436
mock_pubsub_connection.credential_provider = credential_provider
432437
mock_pubsub_connection.retry = Retry(NoBackoff(), 3)
433438
mock_another_connection = Mock(spec=ConnectionInterface)
@@ -488,6 +493,7 @@ def re_auth_callback(token):
488493
def test_do_not_re_auth_pub_sub_in_resp2(self, credential_provider):
489494
mock_pubsub_connection = Mock(spec=ConnectionInterface)
490495
mock_pubsub_connection.get_protocol.return_value = 2
496+
mock_pubsub_connection.should_reconnect = Mock(return_value=False)
491497
mock_pubsub_connection.credential_provider = credential_provider
492498
mock_pubsub_connection.retry = Retry(NoBackoff(), 3)
493499
mock_another_connection = Mock(spec=ConnectionInterface)

tests/test_maint_notifications.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from socket import socket
21
import threading
32
from unittest.mock import Mock, call, patch, MagicMock
43
import pytest

tests/test_maint_notifications_handling.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
from redis.cache import CacheConfig
1111
from redis.connection import (
1212
AbstractConnection,
13-
CacheProxyConnection,
1413
Connection,
1514
ConnectionPool,
1615
BlockingConnectionPool,

0 commit comments

Comments
 (0)