Skip to content

Commit 306bc05

Browse files
authored
Merge branch 'master' into fixing-randomly-failing-test
2 parents f27079a + db8918c commit 306bc05

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

redis/_parsers/helpers.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -396,13 +396,20 @@ def parse_item(item):
396396
# an O(N) complexity) instead of the command.
397397
if isinstance(item[3], list):
398398
result["command"] = space.join(item[3])
399-
result["client_address"] = item[4]
400-
result["client_name"] = item[5]
399+
400+
# These fields are optional, depends on environment.
401+
if len(item) >= 6:
402+
result["client_address"] = item[4]
403+
result["client_name"] = item[5]
401404
else:
402405
result["complexity"] = item[3]
403406
result["command"] = space.join(item[4])
404-
result["client_address"] = item[5]
405-
result["client_name"] = item[6]
407+
408+
# These fields are optional, depends on environment.
409+
if len(item) >= 7:
410+
result["client_address"] = item[5]
411+
result["client_name"] = item[6]
412+
406413
return result
407414

408415
return [parse_item(item) for item in response]

tests/test_json.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1521,8 +1521,8 @@ def test_set_path(client):
15211521

15221522
root = tempfile.mkdtemp()
15231523
sub = tempfile.mkdtemp(dir=root)
1524-
jsonfile = tempfile.mktemp(suffix=".json", dir=sub)
1525-
nojsonfile = tempfile.mktemp(dir=root)
1524+
jsonfile = tempfile.mkstemp(suffix=".json", dir=sub)[1]
1525+
nojsonfile = tempfile.mkstemp(dir=root)[1]
15261526

15271527
with open(jsonfile, "w+") as fp:
15281528
fp.write(json.dumps({"hello": "world"}))

0 commit comments

Comments
 (0)