Skip to content

Commit 4035ce6

Browse files
committed
Revert argument rename, extended documentation
1 parent 471c7cb commit 4035ce6

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

docs/resp3_features.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,10 @@ Enable caching with custom cache implementation:
9898
9999
CacheImpl should implement a `CacheInterface` specified in `redis.cache` package.
100100

101+
Explicit disconnect
102+
103+
It's important to call `disconnect()` or `disconnect_connection_pools()` in case of Cluster to properly close the connection to server.
104+
For caching purposes, we're using a separate thread that performs health checks with configurable interval and it relies on
105+
`disconnect()` or `disconnect_connection_pools()` to be called before the shutdown.
106+
101107
More robust documentation soon will be available at `official Redis documentation <https://redis.io/docs/latest/>`_.

redis/cluster.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,8 +1056,8 @@ def _parse_target_nodes(self, target_nodes):
10561056
)
10571057
return nodes
10581058

1059-
def execute_command(self, *args, **options):
1060-
return self._internal_execute_command(*args, **options)
1059+
def execute_command(self, *args, **kwargs):
1060+
return self._internal_execute_command(*args, **kwargs)
10611061

10621062
def _internal_execute_command(self, *args, **kwargs):
10631063
"""

0 commit comments

Comments
 (0)