Skip to content

Commit 46cfc93

Browse files
committed
Fix hiredis job
1 parent fb50dbd commit 46cfc93

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/actions/run-tests/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ runs:
4141
pip install -r requirements.txt
4242
pip install -r dev_requirements.txt
4343
if [ "${{inputs.parser-backend}}" == "hiredis" ]; then
44-
pip install hiredis${{inputs.hiredis-version}}
44+
pip install "hiredis${{inputs.hiredis-version}}"
4545
echo "PARSER_BACKEND=$(echo "${{inputs.parser-backend}}_${{inputs.hiredis-version}}" | sed 's/[^a-zA-Z0-9]/_/g')" >> $GITHUB_ENV
4646
else
4747
echo "PARSER_BACKEND=${{inputs.parser-backend}}" >> $GITHUB_ENV

.github/workflows/integration.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
event-loop: [ 'asyncio' ]
130130
env:
131131
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
132-
name: Redis ${{ matrix.redis-version }}; Python ${{ matrix.python-version }}; RESP Parser:${{matrix.parser-backend}}; EL:${{matrix.event-loop}}
132+
name: Redis ${{ matrix.redis-version }}; Python ${{ matrix.python-version }}; RESP Parser:${{matrix.parser-backend}} (${{ matrix.hiredis-version }}); EL:${{matrix.event-loop}}
133133
steps:
134134
- uses: actions/checkout@v4
135135
- name: Run tests
@@ -178,6 +178,10 @@ jobs:
178178
with:
179179
python-version: 3.9
180180
- name: Run installed unit tests
181+
env:
182+
REDIS_VERSION: ${{ env.CURRENT_REDIS_VERSION }}
183+
REDIS_IMAGE: "redis:${{ env.CURRENT_REDIS_VERSION }}"
184+
CLIENT_LIBS_TEST_IMAGE: "redislabs/client-libs-test:${{ env.CURRENT_REDIS_VERSION }}"
181185
run: |
182186
bash .github/workflows/install_and_test.sh ${{ matrix.extension }}
183187

0 commit comments

Comments
 (0)