Skip to content

Commit 67fb388

Browse files
committed
Skipping tests based on 8.2.2 version comparison.
1 parent 2830b2a commit 67fb388

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

tests/conftest.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,9 +260,6 @@ def wait_for_cluster_creation(redis_url, cluster_nodes, timeout=60):
260260

261261

262262
def skip_if_server_version_lt(min_version: str) -> _TestDecorator:
263-
print(
264-
f"Current version {REDIS_INFO.get('version', '0')}, skip_if_server_version_lt: {min_version}"
265-
)
266263
redis_version = REDIS_INFO.get("version", "0")
267264
check = Version(redis_version) < Version(min_version)
268265
return pytest.mark.skipif(check, reason=f"Redis version required >= {min_version}")

tests/test_asyncio/test_commands.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3158,7 +3158,7 @@ async def test_xgroup_destroy(self, r: redis.Redis):
31583158
assert await r.xgroup_destroy(stream, group)
31593159

31603160
@skip_if_server_version_lt("7.0.0")
3161-
@skip_if_server_version_gte("8.2.1")
3161+
@skip_if_server_version_gte("8.2.2")
31623162
async def test_xgroup_setid(self, r: redis.Redis):
31633163
stream = "stream"
31643164
group = "group"
@@ -3179,7 +3179,7 @@ async def test_xgroup_setid(self, r: redis.Redis):
31793179
]
31803180
assert await r.xinfo_groups(stream) == expected
31813181

3182-
@skip_if_server_version_lt("8.2.1")
3182+
@skip_if_server_version_lt("8.2.2")
31833183
async def test_xgroup_setid_fixed_max_entries_read(self, r):
31843184
stream = "stream"
31853185
group = "group"

tests/test_commands.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4607,7 +4607,7 @@ def test_xgroup_create_mkstream(self, r):
46074607
assert r.xinfo_groups(stream) == expected
46084608

46094609
@skip_if_server_version_lt("7.0.0")
4610-
@skip_if_server_version_gte("8.2.1")
4610+
@skip_if_server_version_gte("8.2.2")
46114611
def test_xgroup_create_entriesread(self, r: redis.Redis):
46124612
stream = "stream"
46134613
group = "group"
@@ -4629,7 +4629,7 @@ def test_xgroup_create_entriesread(self, r: redis.Redis):
46294629
]
46304630
assert r.xinfo_groups(stream) == expected
46314631

4632-
@skip_if_server_version_lt("8.2.1")
4632+
@skip_if_server_version_lt("8.2.2")
46334633
def test_xgroup_create_entriesread_fixed_max_entries_read(self, r: redis.Redis):
46344634
stream = "stream"
46354635
group = "group"
@@ -4703,7 +4703,7 @@ def test_xgroup_destroy(self, r):
47034703
assert r.xgroup_destroy(stream, group)
47044704

47054705
@skip_if_server_version_lt("7.0.0")
4706-
@skip_if_server_version_gte("8.2.1")
4706+
@skip_if_server_version_gte("8.2.2")
47074707
def test_xgroup_setid(self, r):
47084708
stream = "stream"
47094709
group = "group"
@@ -4724,7 +4724,7 @@ def test_xgroup_setid(self, r):
47244724
]
47254725
assert r.xinfo_groups(stream) == expected
47264726

4727-
@skip_if_server_version_lt("8.2.1")
4727+
@skip_if_server_version_lt("2")
47284728
def test_xgroup_setid_fixed_max_entries_read(self, r):
47294729
stream = "stream"
47304730
group = "group"
@@ -4733,7 +4733,7 @@ def test_xgroup_setid_fixed_max_entries_read(self, r):
47334733

47344734
r.xgroup_create(stream, group, 0)
47354735
# advance the last_delivered_id to the message_id
4736-
r.xgroup_setid(stream, group, message_id, entries_read=2)
4736+
r.xgroup_setid(stream, group, message_id, entries_read=5)
47374737
expected = [
47384738
{
47394739
"name": group.encode(),

0 commit comments

Comments
 (0)