Skip to content

Commit 6f53c02

Browse files
committed
Applying review comments
1 parent 7c600dc commit 6f53c02

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

redis/asyncio/cluster.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1196,13 +1196,14 @@ def __init__(
11961196
self.startup_nodes = {node.name: node for node in startup_nodes}
11971197
self.require_full_coverage = require_full_coverage
11981198
self.connection_kwargs = connection_kwargs
1199-
self._dynamic_startup_nodes = dynamic_startup_nodes
12001199
self.address_remap = address_remap
12011200

12021201
self.default_node: "ClusterNode" = None
12031202
self.nodes_cache: Dict[str, "ClusterNode"] = {}
12041203
self.slots_cache: Dict[int, List["ClusterNode"]] = {}
1205-
self.read_load_balancer = LoadBalancer()
1204+
self.read_load_balancer: LoadBalancer = LoadBalancer()
1205+
1206+
self._dynamic_startup_nodes: bool = dynamic_startup_nodes
12061207
self._moved_exception: MovedError = None
12071208
if event_dispatcher is None:
12081209
self._event_dispatcher = EventDispatcher()

tests/test_asyncio/test_cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2740,7 +2740,7 @@ async def test_init_slots_dynamic_startup_nodes(self, dynamic_startup_nodes):
27402740
]
27412741
startup_nodes = list(rc.nodes_manager.startup_nodes.keys())
27422742
if dynamic_startup_nodes is True:
2743-
assert startup_nodes.sort() == discovered_nodes.sort()
2743+
assert sorted(startup_nodes) == sorted(discovered_nodes)
27442744
else:
27452745
assert startup_nodes == ["[email protected]:7000"]
27462746

0 commit comments

Comments
 (0)