Fixed characters per line restriction

Author: vladvildanov

redis/asyncio/client.py

@@ -27,7 +27,6 @@
 )
 
 from cachetools import Cache
-
 from redis._parsers.helpers import (
     _RedisCallbacks,
     _RedisCallbacksRESP2,

redis/connection.py

@@ -8,12 +8,12 @@
 from abc import abstractmethod
 from itertools import chain
 from queue import Empty, Full, LifoQueue
-from time import time, sleep
+from time import time
 from typing import Any, Callable, List, Optional, Type, Union
 from urllib.parse import parse_qs, unquote, urlparse
 
 from apscheduler.schedulers.background import BackgroundScheduler
-from cachetools import TTLCache, Cache, LRUCache
+from cachetools import Cache, LRUCache
 from cachetools.keys import hashkey
 from redis.cache import CacheConfiguration, CacheFactory
 
@@ -773,13 +773,15 @@ def check_health(self):
         self._conn.check_health()
 
     def send_packed_command(self, command, check_health=True):
-        # TODO: Investigate if it's possible to unpack command or extract keys from packed command
+        # TODO: Investigate if it's possible to unpack command
+        #  or extract keys from packed command
         self._conn.send_packed_command(command)
 
     def send_command(self, *args, **kwargs):
         self._process_pending_invalidations()
 
-        # If command is write command or not allowed to cache, transfer control to the actual connection.
+        # If command is write command or not allowed to cache
+        # transfer control to the actual connection.
         if not self._conf.is_allowed_to_cache(args[0]):
             self._current_command_hash = None
             self._current_command_keys = None
@@ -797,14 +799,17 @@ def send_command(self, *args, **kwargs):
                 raise TypeError("Cache keys must be a list.")
 
         with self._cache_lock:
-            # If current command reply already cached prevent sending data over socket.
+            # If current command reply already cached
+            # prevent sending data over socket.
             if self._cache.get(self._current_command_hash):
                 return
 
-            # Set temporary entry as a status to prevent race condition from another connection.
+            # Set temporary entry as a status to prevent
+            # race condition from another connection.
             self._cache[self._current_command_hash] = "caching-in-progress"
 
-        # Send command over socket only if it's allowed read-only command that not yet cached.
+        # Send command over socket only if it's allowed
+        # read-only command that not yet cached.
         self._conn.send_command(*args, **kwargs)
 
     def can_read(self, timeout=0):
@@ -836,7 +841,8 @@ def read_response(
             elif self._current_command_hash is None:
                 return response
 
-            # Create separate mapping for keys or add current response to associated keys.
+            # Create separate mapping for keys
+            # or add current response to associated keys.
             for key in self._current_command_keys:
                 if key in self._keys_mapping:
                     if self._current_command_hash not in self._keys_mapping[key]:
@@ -846,7 +852,8 @@ def read_response(
 
             cache_entry = self._cache.get(self._current_command_hash, None)
 
-            # Cache only responses that still valid and wasn't invalidated by another connection in meantime.
+            # Cache only responses that still valid
+            # and wasn't invalidated by another connection in meantime.
             if cache_entry is not None:
                 self._cache[self._current_command_hash] = response
 

tests/conftest.py

@@ -330,8 +330,10 @@ def _get_client(
             connection_class = SSLConnection
             kwargs["ssl_certfile"] = get_ssl_filename("client-cert.pem")
             kwargs["ssl_keyfile"] = get_ssl_filename("client-key.pem")
-            # When you try to assign "required" as single string, it assigns tuple instead of string.
-            # Probably some reserved keyword, I can't explain how does it work -_-
+            # When you try to assign "required" as single string
+            # it assigns tuple instead of string.
+            # Probably some reserved keyword
+            # I can't explain how does it work -_-
             kwargs["ssl_cert_reqs"] = "require" + "d"
             kwargs["ssl_ca_certs"] = get_ssl_filename("ca-cert.pem")
             kwargs["port"] = 6666

tests/test_cache.py

@@ -425,7 +425,8 @@ def test_cache_invalidate_all_related_responses(self, r):
         res.append(b"baz")
         assert another_res != res
 
-        # Invalidate one of the keys and make sure that all associated cached entries was removed
+        # Invalidate one of the keys and make sure that
+        # all associated cached entries was removed
         assert r.set("foo", "baz")
         assert r.get("foo") == b"baz"
         assert cache.get(("MGET", "foo", "bar")) is None
@@ -743,7 +744,8 @@ def test_cache_invalidate_all_related_responses(self, r, cache):
         assert r.mget("foo{slot}", "bar{slot}") == [b"bar", b"foo"]
         assert cache.get(("MGET", "foo{slot}", "bar{slot}")) == [b"bar", b"foo"]
 
-        # Invalidate one of the keys and make sure that all associated cached entries was removed
+        # Invalidate one of the keys and make sure
+        # that all associated cached entries was removed
         assert r.set("foo{slot}", "baz")
         assert r.get("foo{slot}") == b"baz"
         assert cache.get(("MGET", "foo{slot}", "bar{slot}")) is None
@@ -1133,7 +1135,8 @@ def test_cache_invalidate_all_related_responses(self, r):
         assert r.mget("foo", "bar") == [b"bar", b"foo"]
         assert cache.get(("MGET", "foo", "bar")) == [b"bar", b"foo"]
 
-        # Invalidate one of the keys and make sure that all associated cached entries was removed
+        # Invalidate one of the keys and make sure
+        # that all associated cached entries was removed
         assert r.set("foo", "baz")
         assert r.get("foo") == b"baz"
         assert cache.get(("MGET", "foo", "bar")) is None