Adding several missed input validations and unit test coverage for them

Author: petyaslavova

redis/commands/core.py

@@ -4959,6 +4959,9 @@ def hgetdel(
         Available since Redis 8.0
         For more information see https://redis.io/commands/hgetdel
         """
+        if len(keys) == 0:
+            raise DataError("'hgetdel' should have at least one key provided")
+
         return self.execute_command("HGETDEL", name, "FIELDS", len(keys), *keys)
 
     def hgetex(
@@ -4990,6 +4993,10 @@ def hgetex(
         Available since Redis 8.0
         For more information see https://redis.io/commands/hgetex
         """
+
+        if len(keys) == 0:
+            raise DataError("'hgetex' should have at least one key provided")
+
         opset = {ex, px, exat, pxat}
         if len(opset) > 2 or len(opset) > 1 and persist:
             raise DataError(
@@ -5060,8 +5067,10 @@ def hset(
 
         For more information see https://redis.io/commands/hset
         """
+
         if key is None and not mapping and not items:
             raise DataError("'hset' with no key value pairs")
+
         pieces = []
         if items:
             pieces.extend(items)
@@ -5123,6 +5132,12 @@ def hsetex(
         if key is None and not mapping and not items:
             raise DataError("'hsetex' with no key value pairs")
 
+        if items and len(items) % 2 != 0:
+            raise DataError(
+                "'hsetex' with odd number of items. "
+                "'items' must contain a list of key/value pairs."
+            )
+
         opset = {ex, px, exat, pxat}
         if len(opset) > 2 or len(opset) > 1 and keepttl:
             raise DataError(

tests/test_asyncio/test_hash.py

@@ -316,6 +316,9 @@ async def test_hgetdel(r):
     assert await r.hgetdel("test:hash", "foo", "1") == [None, None]
     assert await r.hget("test:hash", "2") == b"2"
 
+    with pytest.raises(exceptions.DataError):
+        await r.hgetdel("test:hash")
+
 
 @skip_if_server_version_lt("7.9.0")
 async def test_hgetex_no_expiration(r):
@@ -396,6 +399,9 @@ async def test_hgetex_invalid_inputs(r):
     with pytest.raises(exceptions.DataError):
         await r.hgetex("b", "foo", "1", "3", ex=10, px=6000)
 
+    with pytest.raises(exceptions.DataError):
+        await r.hgetex("b", ex=10)
+
 
 @skip_if_server_version_lt("7.9.0")
 async def test_hsetex_no_expiration(r):
@@ -545,6 +551,9 @@ async def test_hsetex_invalid_inputs(r):
     with pytest.raises(exceptions.DataError):
         await r.hsetex("b", None, None)
 
+    with pytest.raises(exceptions.DataError):
+        await r.hsetex("b", "foo", "bar", items=["i1", 11, "i2"], px=6000)
+
     with pytest.raises(exceptions.DataError):
         await r.hsetex("b", "foo", "bar", ex=10, keepttl=True)
 

tests/test_hash.py

@@ -383,6 +383,9 @@ def test_hgetdel(r):
     assert r.hgetdel("test:hash", "foo", "1") == [None, None]
     assert r.hget("test:hash", "2") == b"2"
 
+    with pytest.raises(exceptions.DataError):
+        r.hgetdel("test:hash")
+
 
 @skip_if_server_version_lt("7.9.0")
 def test_hgetex_no_expiration(r):
@@ -445,6 +448,9 @@ def test_hgetex_invalid_inputs(r):
     with pytest.raises(exceptions.DataError):
         r.hgetex("b", "foo", "1", "3", ex=10, px=6000)
 
+    with pytest.raises(exceptions.DataError):
+        r.hgetex("b", ex=10)
+
 
 @skip_if_server_version_lt("7.9.0")
 def test_hsetex_no_expiration(r):
@@ -454,7 +460,6 @@ def test_hsetex_no_expiration(r):
     assert r.hsetex("test:hash", None, None, mapping={"1": 1, "4": b"four"}) == 1
     assert r.httl("test:hash", "foo", "1", "4") == [-2, -1, -1]
     assert r.hgetex("test:hash", "foo", "1") == [None, b"1"]
-    pass
 
 
 @skip_if_server_version_lt("7.9.0")
@@ -584,6 +589,9 @@ def test_hsetex_invalid_inputs(r):
     with pytest.raises(exceptions.DataError):
         r.hsetex("b", None, None)
 
+    with pytest.raises(exceptions.DataError):
+        r.hsetex("b", "foo", "bar", items=["i1", 11, "i2"], px=6000)
+
     with pytest.raises(exceptions.DataError):
         r.hsetex("b", "foo", "bar", ex=10, keepttl=True)