Skip to content

Commit 81c02be

Browse files
committed
Revert changing of the default retry object initialization for connection pool - this should be a separate PR
1 parent 82086bc commit 81c02be

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

redis/connection.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
from ._parsers import Encoder, _HiredisParser, _RESP2Parser, _RESP3Parser
2626
from .auth.token import TokenInterface
27-
from .backoff import ExponentialWithJitterBackoff
27+
from .backoff import NoBackoff
2828
from .credentials import CredentialProvider, UsernamePasswordCredentialProvider
2929
from .event import AfterConnectionReleasedEvent, EventDispatcher
3030
from .exceptions import (
@@ -322,15 +322,16 @@ def __init__(
322322
# Add TimeoutError to the errors list to retry on
323323
retry_on_error.append(TimeoutError)
324324
self.retry_on_error = retry_on_error
325-
if retry is None:
326-
self.retry = Retry(
327-
backoff=ExponentialWithJitterBackoff(base=1, cap=10), retries=3
328-
)
329-
else:
330-
# deep-copy the Retry object as it is mutable
331-
self.retry = copy.deepcopy(retry)
332-
if retry_on_error:
325+
if retry or retry_on_error:
326+
if retry is None:
327+
self.retry = Retry(NoBackoff(), 1)
328+
else:
329+
# deep-copy the Retry object as it is mutable
330+
self.retry = copy.deepcopy(retry)
331+
# Update the retry's supported errors with the specified errors
333332
self.retry.update_supported_errors(retry_on_error)
333+
else:
334+
self.retry = Retry(NoBackoff(), 0)
334335
self.health_check_interval = health_check_interval
335336
self.next_health_check = 0
336337
self.redis_connect_func = redis_connect_func

0 commit comments

Comments
 (0)