Skip to content

Commit 96c6e5d

Browse files
committed
Revert changing of the default retry object initialization for connection pool - this should be a separate PR
1 parent 5c71733 commit 96c6e5d

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

redis/connection.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
from ._parsers import Encoder, _HiredisParser, _RESP2Parser, _RESP3Parser
2626
from .auth.token import TokenInterface
27-
from .backoff import ExponentialWithJitterBackoff
27+
from .backoff import NoBackoff
2828
from .credentials import CredentialProvider, UsernamePasswordCredentialProvider
2929
from .event import AfterConnectionReleasedEvent, EventDispatcher
3030
from .exceptions import (
@@ -323,15 +323,16 @@ def __init__(
323323
# Add TimeoutError to the errors list to retry on
324324
retry_on_error.append(TimeoutError)
325325
self.retry_on_error = retry_on_error
326-
if retry is None:
327-
self.retry = Retry(
328-
backoff=ExponentialWithJitterBackoff(base=1, cap=10), retries=3
329-
)
330-
else:
331-
# deep-copy the Retry object as it is mutable
332-
self.retry = copy.deepcopy(retry)
333-
if retry_on_error:
326+
if retry or retry_on_error:
327+
if retry is None:
328+
self.retry = Retry(NoBackoff(), 1)
329+
else:
330+
# deep-copy the Retry object as it is mutable
331+
self.retry = copy.deepcopy(retry)
332+
# Update the retry's supported errors with the specified errors
334333
self.retry.update_supported_errors(retry_on_error)
334+
else:
335+
self.retry = Retry(NoBackoff(), 0)
335336
self.health_check_interval = health_check_interval
336337
self.next_health_check = 0
337338
self.redis_connect_func = redis_connect_func

0 commit comments

Comments
 (0)