Skip to content

Commit 9c012ce

Browse files
committed
Fix bash script in run-tests
1 parent 7248d09 commit 9c012ce

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

.github/actions/run-tests/action.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ runs:
3434
REDIS_IMAGE: "redis:${{ inputs.redis-version }}"
3535
CLIENT_LIBS_TEST_IMAGE: "redislabs/client-libs-test:${{ inputs.redis-version }}"
3636
run: |
37+
set -e
3738
pip install -U setuptools wheel
3839
pip install -r requirements.txt
3940
pip install -r dev_requirements.txt
@@ -43,7 +44,7 @@ runs:
4344
4445
redis_major_version=$(echo "$REDIS_VERSION" | grep -oP '^\d+')
4546
46-
if (( major_version < 8 )); then
47+
if (( redis_major_version < 8 )); then
4748
echo "Using redis-stack for module tests"
4849
4950
# Mapping of redis version to stack version
@@ -55,15 +56,15 @@ runs:
5556
5657
if [[ -v version_mapping[$REDIS_VERSION] ]]; then
5758
export REDIS_STACK_IMAGE="redis/redis-stack-server:${version_mapping[$version]}"
58-
echo "REDISMOD_URL=redis://127.0.0.1:6479/0" >> $GITHUB_ENV
59+
echo "REDIS_MOD_URL=redis://127.0.0.1:6479/0" >> $GITHUB_ENV
5960
else
6061
echo "Version not found in the mapping."
6162
exit 1
6263
fi
63-
invoke devenv --endpoints all-stack
64+
invoke devenv --endpoints=all-stack
6465
else
6566
echo "Using redis CE for module tests"
66-
echo "REDISMOD_URL=redis://127.0.0.1:6379" >> $GITHUB_ENV
67+
echo "REDIS_MOD_URL=redis://127.0.0.1:6379" >> $GITHUB_ENV
6768
invoke devenv --endpoints all
6869
fi
6970
@@ -73,25 +74,25 @@ runs:
7374
- name: Run RESP2 tests
7475
run: |
7576
if [ "${{inputs.event-loop}}" == "uvloop" ]; then
76-
invoke standalone-tests --redis-mod-url=${REDISMOD_URL} --uvloop --protocol=2
77+
invoke standalone-tests --redis-mod-url=${REDIS_MOD_URL} --uvloop --protocol=2
7778
invoke cluster-tests --uvloop --protocol=2
7879
else
79-
invoke standalone-tests --redis-mod-url=${REDISMOD_URL} --protocol=2
80+
invoke standalone-tests --redis-mod-url=${REDIS_MOD_URL} --protocol=2
8081
invoke cluster-tests --protocol=2
8182
fi
8283
shell: bash
8384

8485
- name: Run RESP3 tests
8586
run: |
8687
if [ "${{inputs.event-loop}}" == "uvloop" ]; then
87-
invoke standalone-tests --redis-mod-url=${REDISMOD_URL} --uvloop --protocol=3
88+
invoke standalone-tests --redis-mod-url=${REDIS_MOD_URL} --uvloop --protocol=3
8889
8990
# hiredis does not support RESP3 on cluster
9091
if [ "${{inputs.parser-backend}}" != 'hiredis' ]; then
9192
invoke cluster-tests --uvloop --protocol=3
9293
fi
9394
else
94-
invoke standalone-tests --redis-mod-url=${REDISMOD_URL} --protocol=3
95+
invoke standalone-tests --redis-mod-url=${REDIS_MOD_URL} --protocol=3
9596
9697
# hiredis does not support RESP3 on cluster
9798
if [ "${{inputs.parser-backend}}" != 'hiredis' ]; then

0 commit comments

Comments
 (0)