Skip test for RESP3 and add async test

Author: uglide

tests/test_asyncio/test_search.py

@@ -4,15 +4,22 @@
 import time
 from io import TextIOWrapper
 
+import numpy as np
 import pytest
 import pytest_asyncio
 import redis.asyncio as redis
 import redis.commands.search
 import redis.commands.search.aggregation as aggregations
 import redis.commands.search.reducers as reducers
 from redis.commands.search import AsyncSearch
-from redis.commands.search.field import GeoField, NumericField, TagField, TextField
-from redis.commands.search.indexDefinition import IndexDefinition
+from redis.commands.search.field import (
+    GeoField,
+    NumericField,
+    TagField,
+    TextField,
+    VectorField,
+)
+from redis.commands.search.indexDefinition import IndexDefinition, IndexType
 from redis.commands.search.query import GeoFilter, NumericFilter, Query
 from redis.commands.search.result import Result
 from redis.commands.search.suggestion import Suggestion
@@ -21,6 +28,7 @@
     is_resp2_connection,
     skip_if_redis_enterprise,
     skip_ifmodversion_lt,
+    skip_if_resp_version,
 )
 
 WILL_PLAY_TEXT = os.path.abspath(
@@ -37,6 +45,11 @@ async def decoded_r(create_redis, stack_url):
     return await create_redis(decode_responses=True, url=stack_url)
 
 
+@pytest_asyncio.fixture()
+async def binary_client(create_redis, stack_url):
+    return await create_redis(decode_responses=False, url=stack_url)
+
+
 async def waitForIndex(env, idx, timeout=None):
     delay = 0.1
     while True:
@@ -1560,3 +1573,61 @@ async def test_query_timeout(decoded_r: redis.Redis):
     q2 = Query("foo").timeout("not_a_number")
     with pytest.raises(redis.ResponseError):
         await decoded_r.ft().search(q2)
+
+
+@pytest.mark.redismod
+@skip_if_resp_version(3)
+async def test_binary_and_text_fields(binary_client):
+    assert (
+        binary_client.get_connection_kwargs()["decode_responses"] is False
+    ), "This feature is only available when decode_responses is False"
+
+    fake_vec = np.array([0.1, 0.2, 0.3, 0.4], dtype=np.float32)
+
+    index_name = "mixed_index"
+    mixed_data = {"first_name": "🐍python", "vector_emb": fake_vec.tobytes()}
+    await binary_client.hset(f"{index_name}:1", mapping=mixed_data)
+
+    schema = (
+        TagField("first_name"),
+        VectorField(
+            "embeddings_bio",
+            algorithm="HNSW",
+            attributes={
+                "TYPE": "FLOAT32",
+                "DIM": 4,
+                "DISTANCE_METRIC": "COSINE",
+            },
+        ),
+    )
+
+    await binary_client.ft(index_name).create_index(
+        fields=schema,
+        definition=IndexDefinition(
+            prefix=[f"{index_name}:"], index_type=IndexType.HASH
+        ),
+    )
+
+    bytes_person_1 = await binary_client.hget(f"{index_name}:1", "vector_emb")
+    decoded_vec_from_hash = np.frombuffer(bytes_person_1, dtype=np.float32)
+    assert np.array_equal(decoded_vec_from_hash, fake_vec), "The vectors are not equal"
+
+    query = (
+        Query("*")
+        .return_field("vector_emb", decode_field=False)
+        .return_field("first_name", decode_field=True)
+    )
+    result = await binary_client.ft(index_name).search(query=query, query_params={})
+    docs = result.docs
+
+    decoded_vec_from_search_results = np.frombuffer(
+        docs[0]["vector_emb"], dtype=np.float32
+    )
+
+    assert np.array_equal(
+        decoded_vec_from_search_results, fake_vec
+    ), "The vectors are not equal"
+
+    assert (
+        docs[0]["first_name"] == mixed_data["first_name"]
+    ), "The first is not decoded correctly"

tests/test_search.py

@@ -31,6 +31,7 @@
     is_resp2_connection,
     skip_if_redis_enterprise,
     skip_ifmodversion_lt,
+    skip_if_resp_version,
 )
 
 WILL_PLAY_TEXT = os.path.abspath(
@@ -116,7 +117,9 @@ def client(request, stack_url):
 
 @pytest.fixture
 def binary_client(request, stack_url):
-    r = _get_client(redis.Redis, request, decode_responses=False, from_url=stack_url)
+    r = _get_client(
+        redis.Redis, request, decode_responses=False, from_url=stack_url, protocol=3
+    )
     r.flushdb()
     return r
 
@@ -1714,6 +1717,7 @@ def test_search_return_fields(client):
 
 
 @pytest.mark.redismod
+@skip_if_resp_version(3)
 def test_binary_and_text_fields(binary_client):
     assert (
         binary_client.get_connection_kwargs()["decode_responses"] is False