lint and format

Author: agnesnatasya

redis/asyncio/sentinel.py

@@ -1,8 +1,16 @@
 import asyncio
 import random
 import weakref
-import uuid
-from typing import AsyncIterator, Iterable, Mapping, Optional, Sequence, Tuple, Type, Any
+from typing import (
+    Any,
+    AsyncIterator,
+    Iterable,
+    Mapping,
+    Optional,
+    Sequence,
+    Tuple,
+    Type,
+)
 
 from redis.asyncio.client import Redis
 from redis.asyncio.connection import (
@@ -66,13 +74,13 @@ async def connect(self):
             self._connect_retry,
             lambda error: asyncio.sleep(0),
         )
-    
+
     async def _connect_to_address_retry(self, host: str, port: int) -> None:
         if self._reader:
             return  # already connected
         try:
             return await self.connect_to((host, port))
-        except ConnectionError as exc:
+        except ConnectionError:
             raise SlaveNotFoundError
 
     async def connect_to_address(self, host: str, port: int) -> None:
@@ -170,11 +178,6 @@ async def get_master_address(self):
 
     async def rotate_slaves(self) -> AsyncIterator:
         """Round-robin slave balancer"""
-        (
-            server_host,
-            server_port,
-        ) = self._request_id_to_replica_address.get(iter_req_id, (None, None))
-        
         slaves = await self.sentinel_manager.discover_slaves(self.service_name)
         if slaves:
             if self.slave_rr_counter is None:
@@ -201,15 +204,15 @@ async def get_connection(
         to be issued to the same Redis replica.
 
         The way each server positions each key is different with one another,
-        and the cursor acts as the 'offset' of the scan. 
-        Hence, all scans coming from a single xxx_scan_iter_channel command 
+        and the cursor acts as the 'offset' of the scan.
+        Hence, all scans coming from a single xxx_scan_iter_channel command
         should go to the same replica.
         """
         # If not an iter command or in master mode, call super()
         # No custom logic for master, because there's only 1 master.
         # The bug is only when Redis has the possibility to connect to multiple replicas
         if not (iter_req_id := options.get("_iter_req_id", None)) or self.is_master:
-            return await super().get_connection(command_name, *keys, **options)  # type: ignore[no-any-return]
+            return await super().get_connection(command_name, *keys, **options)
 
         # Check if this iter request has already been directed to a particular server
         # Check if this iter request has already been directed to a particular server
@@ -222,7 +225,7 @@ async def get_connection(
         # get a connection from the pool
         if server_host is None or server_port is None:
             try:
-                connection = self._available_connections.pop()  # type: ignore [assignment]
+                connection = self._available_connections.pop()
             except IndexError:
                 connection = self.make_connection()
         # If this is not the first scan request of the iter command
@@ -236,7 +239,7 @@ async def get_connection(
                     and available_connection.port == server_port
                 ):
                     self._available_connections.remove(available_connection)
-                    connection = available_connection  # type: ignore[assignment]
+                    connection = available_connection
             # If not, make a new dummy connection object, and set its host and port
             # to the one that we want later in the call to ``connect_to_address``
             if not connection:
@@ -255,22 +258,18 @@ async def get_connection(
             # connect to the particular address and port
             else:
                 # This will connect to the host and port that we've specified above
-                await connection.connect_to_address(server_host, server_port)  # type: ignore[arg-type]
+                await connection.connect_to_address(server_host, server_port)
             # connections that the pool provides should be ready to send
             # a command. if not, the connection was either returned to the
             # pool before all data has been read or the socket has been
             # closed. either way, reconnect and verify everything is good.
             try:
-                # type ignore below:
-                # attr Not defined in redis stubs and
-                # we don't need to create a subclass to help with this single attr
-                if await connection.can_read_destructive():  # type: ignore[attr-defined]
+                if await connection.can_read_destructive():
                     raise ConnectionError("Connection has data") from None
             except (ConnectionError, OSError):
                 await connection.disconnect()
                 await connection.connect()
-                # type ignore below: similar to above
-                if await connection.can_read_destructive():  # type: ignore[attr-defined]
+                if await connection.can_read_destructive():
                     raise ConnectionError("Connection not ready") from None
         except BaseException:
             # release the connection back to the pool so that we don't
@@ -286,7 +285,6 @@ async def get_connection(
         return connection
 
 
-
 class Sentinel(AsyncSentinelCommands):
     """
     Redis Sentinel cluster client

redis/commands/core.py

@@ -1,8 +1,8 @@
 # from __future__ import annotations
 
-import uuid
 import datetime
 import hashlib
+import uuid
 import warnings
 from typing import (
     TYPE_CHECKING,
@@ -3226,12 +3226,19 @@ async def scan_iter(
             HASH, LIST, SET, STREAM, STRING, ZSET
             Additionally, Redis modules can expose other types as well.
         """
-        # DO NOT inline this statement to the scan call
-        iter_req_id = uuid.uuid4() # each iter command should have an ID to maintain connection to the same replica
+        #  DO NOT inline this statement to the scan call
+        #  Each iter command should have an ID to maintain
+        #  connection to the same replica
+        iter_req_id = uuid.uuid4()
         cursor = "0"
         while cursor != 0:
             cursor, data = await self.scan(
-                cursor=cursor, match=match, count=count, _type=_type, _iter_req_id=iter_req_id, **kwargs
+                cursor=cursor,
+                match=match,
+                count=count,
+                _type=_type,
+                _iter_req_id=iter_req_id,
+                **kwargs,
             )
             for d in data:
                 yield d
@@ -3250,8 +3257,10 @@ async def sscan_iter(
 
         ``count`` allows for hint the minimum number of returns
         """
-        # DO NOT inline this statement to the scan call
-        iter_req_id = uuid.uuid4() # each iter command should have an ID to maintain connection to the same replica
+        #  DO NOT inline this statement to the scan call
+        #  Each iter command should have an ID to maintain
+        #  connection to the same replica
+        iter_req_id = uuid.uuid4()
         cursor = "0"
         while cursor != 0:
             cursor, data = await self.sscan(
@@ -3277,8 +3286,10 @@ async def hscan_iter(
 
         ``no_values`` indicates to return only the keys, without values
         """
-        # DO NOT inline this statement to the scan call
-        iter_req_id = uuid.uuid4() # each iter command should have an ID to maintain connection to the same replica
+        #  DO NOT inline this statement to the scan call
+        #  Each iter command should have an ID to maintain
+        #  connection to the same replica
+        iter_req_id = uuid.uuid4()
         cursor = "0"
         while cursor != 0:
             cursor, data = await self.hscan(
@@ -3312,8 +3323,10 @@ async def zscan_iter(
 
         ``score_cast_func`` a callable used to cast the score return value
         """
-        # DO NOT inline this statement to the scan call
-        iter_req_id = uuid.uuid4() # each iter command should have an ID to maintain connection to the same replica
+        #  DO NOT inline this statement to the scan call
+        #  Each iter command should have an ID to maintain
+        #  connection to the same replica
+        iter_req_id = uuid.uuid4()
         cursor = "0"
         while cursor != 0:
             cursor, data = await self.zscan(
@@ -3322,7 +3335,7 @@ async def zscan_iter(
                 match=match,
                 count=count,
                 score_cast_func=score_cast_func,
-                _iter_req_id=iter_req_id
+                _iter_req_id=iter_req_id,
             )
             for d in data:
                 yield d