mock can_read_destructive for parser

Author: agnesnatasya

redis/asyncio/sentinel.py

@@ -71,10 +71,10 @@ async def _connect_retry(self):
         # If address is fixed, it means that the connection
         # is not rotating to the next slave (if the connection pool is in replica mode)
         if self._is_address_fixed:
-            self.connect_to(self.host, self.port)
+            await self.connect_to((self.host, self.port))
             return
         await self._connect_to_sentinel()
-    
+
     async def _connect_to_sentinel(self):
         # If same_server is False, connnect to master in master mode
         # and rotate to the next slave in slave mode

redis/sentinel.py

@@ -59,7 +59,7 @@ def _connect_retry(self):
             self.connect_to((self.host, self.port))
             return
         self._connect_to_sentinel()
-    
+
     def _connect_to_sentinel(self):
         # If same_server is False, connnect to master in master mode
         # and rotate to the next slave in slave mode

tests/test_asyncio/test_sentinel_managed_connection.py

@@ -1,5 +1,5 @@
 import socket
-from typing import Tuple
+from typing import Iterator, Tuple
 
 import pytest
 from redis.asyncio.retry import Retry
@@ -59,35 +59,46 @@ async def _connect_to_sentinel(self) -> None:
             self.host = f"host-{random.randint(0, 10)}"
             self.port = time.time()
 
+    async def connect_to(self, address: Tuple[str, int]) -> None:
+        """
+        Do nothing, just mock.
+        """
+
 
 @pytest.fixture()
-def connection_pool_replica_mock() -> SentinelConnectionPool:
+def connection_pool_replica_mock() -> Iterator[SentinelConnectionPool]:
     sentinel_manager = Sentinel([["master", 400]])
     # Give a random slave
     sentinel_manager.discover_slaves = mock.AsyncMock(return_value=["replica", 5000])
-    # Create connection pool with our mock connection object
-    connection_pool = SentinelConnectionPool(
-        "usasm",
-        sentinel_manager,
-        is_master=False,
-        connection_class=SentinelManagedConnectionMock,
-    )
-    return connection_pool
+    with mock.patch(
+        "redis._parsers._AsyncRESP2Parser.can_read_destructive", return_value=False
+    ):
+        # Create connection pool with our mock connection object
+        connection_pool = SentinelConnectionPool(
+            "usasm",
+            sentinel_manager,
+            is_master=False,
+            connection_class=SentinelManagedConnectionMock,
+        )
+        yield connection_pool
 
 
 @pytest.fixture()
-def connection_pool_master_mock() -> SentinelConnectionPool:
+def connection_pool_master_mock() -> Iterator[SentinelConnectionPool]:
     sentinel_manager = Sentinel([["master", 400]])
     # Give a random slave
     sentinel_manager.discover_master = mock.AsyncMock(return_value=["replica", 5000])
-    # Create connection pool with our mock connection object
-    connection_pool = SentinelConnectionPool(
-        "usasm",
-        sentinel_manager,
-        is_master=True,
-        connection_class=SentinelManagedConnectionMock,
-    )
-    return connection_pool
+    with mock.patch(
+        "redis._parsers._AsyncRESP2Parser.can_read_destructive", return_value=False
+    ):
+        # Create connection pool with our mock connection object
+        connection_pool = SentinelConnectionPool(
+            "usasm",
+            sentinel_manager,
+            is_master=True,
+            connection_class=SentinelManagedConnectionMock,
+        )
+        yield connection_pool
 
 
 def same_address(

tests/test_sentinel_managed_connection.py

@@ -23,16 +23,11 @@ def _connect_to_sentinel(self) -> None:
             self.host = f"host-{random.randint(0, 10)}"
             self.port = time.time()
 
-
-class SentinelManagedConnectionMock(SentinelManagedConnectionMock):
     def connect_to(self, address: Tuple[str, int]) -> None:
         """
-        This simulates the behavior of connect_to when
-        :py:class:`~redis.SentinelConnectionPool`
-        is in master mode.
-        It'll try to connect to master. In this mock class,
-        it'll just set the host and port without actually connecting.
+        Do nothing, this is just to mock.
         """
+        pass
 
 
 @pytest.fixture()