Skip to content

Commit ecf10fe

Browse files
committed
Fixed issue with invoking _close() on closed event loop
1 parent 00f5be4 commit ecf10fe

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

redis/asyncio/connection.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,13 @@ def __del__(self, _warnings: Any = warnings):
214214
_warnings.warn(
215215
f"unclosed Connection {self!r}", ResourceWarning, source=self
216216
)
217-
self._close()
217+
218+
try:
219+
asyncio.get_running_loop()
220+
self._close()
221+
except RuntimeError:
222+
# No actions been taken if pool already closed.
223+
pass
218224

219225
def _close(self):
220226
"""

redis/asyncio/sentinel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def __init__(self, service_name, sentinel_manager, **kwargs):
117117
self.is_master = kwargs.pop("is_master", True)
118118
self.check_connection = kwargs.pop("check_connection", False)
119119
super().__init__(**kwargs)
120-
self.connection_kwargs["connection_pool"] = weakref.proxy(self)
120+
self.connection_kwargs["connection_pool"] = self
121121
self.service_name = service_name
122122
self.sentinel_manager = sentinel_manager
123123
self.master_address = None

0 commit comments

Comments
 (0)