Adding integration tests with the different load balancing strategies for read operation

Author: petyaslavova

tests/test_asyncio/test_cluster.py

@@ -35,6 +35,9 @@
     ResponseError,
 )
 from redis.utils import str_if_bytes
+from tests.test_asyncio.conftest import (
+    create_redis,
+)
 from tests.conftest import (
     assert_resp_response,
     is_resp2_connection,
@@ -706,7 +709,7 @@ def cmd_init_mock(self, r: ClusterNode) -> None:
             (False, LoadBalancingStrategy.RANDOM_REPLICA, [7002, 7002, 7002]),
         ],
     )
-    async def test_reading_from_replicas_in_round_robin(
+    async def test_reading_with_load_balancing_strategies(
         self,
         read_from_replicas: bool,
         load_balancing_strategy: LoadBalancingStrategy,
@@ -1008,6 +1011,31 @@ async def test_get_and_set(self, r: RedisCluster) -> None:
         assert await r.get("integer") == str(integer).encode()
         assert (await r.get("unicode_string")).decode("utf-8") == unicode_string
 
+    @pytest.mark.parametrize(
+        "load_balancing_strategy",
+        [
+            LoadBalancingStrategy.ROUND_ROBIN,
+            LoadBalancingStrategy.ROUND_ROBIN_REPLICAS,
+            LoadBalancingStrategy.RANDOM_REPLICA,
+        ],
+    )
+    async def test_get_and_set_with_load_balanced_client(
+        self, create_redis, load_balancing_strategy: LoadBalancingStrategy
+    ) -> None:
+        r = await create_redis(cls=RedisCluster, load_balancing_strategy=load_balancing_strategy)
+
+        # get and set can't be tested independently of each other
+        assert await r.get("a") is None
+
+        byte_string = b"value"
+        assert await r.set("byte_string", byte_string)
+
+        # run the get command for the same key several times
+        # to iterate over the read nodes
+        assert await r.get("byte_string") == byte_string
+        assert await r.get("byte_string") == byte_string
+        assert await r.get("byte_string") == byte_string
+
     async def test_mget_nonatomic(self, r: RedisCluster) -> None:
         assert await r.mget_nonatomic([]) == []
         assert await r.mget_nonatomic(["a", "b"]) == [None, None]

tests/test_cluster.py

@@ -615,7 +615,7 @@ def cmd_init_mock(self, r):
             (False, LoadBalancingStrategy.RANDOM_REPLICA, [7002, 7002, 7002]),
         ],
     )
-    def test_reading_from_replicas_in_round_robin(
+    def test_reading_with_load_balancing_strategies(
         self,
         read_from_replicas: bool,
         load_balancing_strategy: LoadBalancingStrategy,
@@ -1020,6 +1020,35 @@ def test_get_and_set(self, r):
         assert r.get("integer") == str(integer).encode()
         assert r.get("unicode_string").decode("utf-8") == unicode_string
 
+    @pytest.mark.parametrize(
+        "load_balancing_strategy",
+        [
+            LoadBalancingStrategy.ROUND_ROBIN,
+            LoadBalancingStrategy.ROUND_ROBIN_REPLICAS,
+            LoadBalancingStrategy.RANDOM_REPLICA,
+        ],
+    )
+    def test_get_and_set_with_load_balanced_client(
+        self, request, load_balancing_strategy: LoadBalancingStrategy
+    ) -> None:
+        r = _get_client(
+            cls=RedisCluster,
+            request=request,
+            load_balancing_strategy=load_balancing_strategy
+        )
+
+        # get and set can't be tested independently of each other
+        assert r.get("a") is None
+
+        byte_string = b"value"
+        assert r.set("byte_string", byte_string)
+
+        # run the get command for the same key several times
+        # to iterate over the read nodes
+        assert r.get("byte_string") == byte_string
+        assert r.get("byte_string") == byte_string
+        assert r.get("byte_string") == byte_string
+
     def test_mget_nonatomic(self, r):
         assert r.mget_nonatomic([]) == []
         assert r.mget_nonatomic(["a", "b"]) == [None, None]