Merge pull request #1316 from viralpraxis/make-unlink-consistent-with-del-when-empty-keyset-passed

Make `unlink` consistent with `del` when an empty keyset passed

Author: byroot

lib/redis/commands/keys.rb

@@ -261,6 +261,9 @@ def del(*keys)
       # @param [String, Array<String>] keys
       # @return [Integer] number of keys that were unlinked
       def unlink(*keys)
+        keys.flatten!(1)
+        return 0 if keys.empty?
+
         send_command([:unlink] + keys)
       end
 

test/redis/commands_on_value_types_test.rb

@@ -49,6 +49,10 @@ def test_unlink
 
     assert_equal ["bar", "baz", "foo"], r.keys("*").sort
 
+    assert_equal 0, r.unlink("")
+
+    assert_equal ["bar", "baz", "foo"], r.keys("*").sort
+
     assert_equal 1, r.unlink("foo")
 
     assert_equal ["bar", "baz"], r.keys("*").sort
@@ -62,15 +66,24 @@ def test_unlink_with_array_argument
     r.set "foo", "s1"
     r.set "bar", "s2"
     r.set "baz", "s3"
+    r.set "bad", "s4"
 
-    assert_equal ["bar", "baz", "foo"], r.keys("*").sort
+    assert_equal ["bad", "bar", "baz", "foo"], r.keys("*").sort
+
+    assert_equal 0, r.unlink([])
+
+    assert_equal ["bad", "bar", "baz", "foo"], r.keys("*").sort
 
     assert_equal 1, r.unlink(["foo"])
 
-    assert_equal ["bar", "baz"], r.keys("*").sort
+    assert_equal ["bad", "bar", "baz"], r.keys("*").sort
 
     assert_equal 2, r.unlink(["bar", "baz"])
 
+    assert_equal ["bad"], r.keys("*").sort
+
+    assert_equal 1, r.unlink([["bad"]])
+
     assert_equal [], r.keys("*").sort
   end