Merge pull request #1136 from fatkodima/rpop-lpop-missing-key

Add tests for `lpop`/`rpop` with the missing key

Author: byroot

lib/redis/commands/lists.rb

@@ -99,7 +99,7 @@ def rpushx(key, value)
       #
       # @param [String] key
       # @param [Integer] count number of elements to remove
-      # @return [String, Array<String>] the values of the first elements
+      # @return [nil, String, Array<String>] the values of the first elements
       def lpop(key, count = nil)
         command = [:lpop, key]
         command << Integer(count) if count
@@ -110,7 +110,7 @@ def lpop(key, count = nil)
       #
       # @param [String] key
       # @param [Integer] count number of elements to remove
-      # @return [String, Array<String>] the values of the last elements
+      # @return [nil, String, Array<String>] the values of the last elements
       def rpop(key, count = nil)
         command = [:rpop, key]
         command << Integer(count) if count

test/lint/lists.rb

@@ -140,6 +140,7 @@ def test_lpop
       assert_equal 2, r.llen("foo")
       assert_equal "s1", r.lpop("foo")
       assert_equal 1, r.llen("foo")
+      assert_nil r.lpop("nonexistent")
     end
 
     def test_lpop_count
@@ -160,6 +161,7 @@ def test_rpop
       assert_equal 2, r.llen("foo")
       assert_equal "s2", r.rpop("foo")
       assert_equal 1, r.llen("foo")
+      assert_nil r.rpop("nonexistent")
     end
 
     def test_rpop_count