Remove the deprecated queue and commit methods

Author: byroot

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 # Unreleased 5.0.0
 
+- Removed the deprecated `queue` and `commit` methods. Use `pipelined` instead.
 - Removed the deprecated `pipelined` and `multi` signature. Commands now MUST be called on the block argument, not the original redis instance.
 - Removed `Redis.current`. You shouldn't assume there is a single global Redis connection, use a connection pool instead,
   and libaries using Redis should accept a Redis instance (or connection pool) as a config. E.g. `MyLibrary.redis = Redis.new(...)`.

lib/redis.rb

@@ -90,47 +90,6 @@ def with
     yield self
   end
 
-  # @deprecated Queues a command for pipelining.
-  #
-  # Commands in the queue are executed with the Redis#commit method.
-  #
-  # See http://redis.io/topics/pipelining for more details.
-  #
-  def queue(*command)
-    ::Redis.deprecate!(
-      "Redis#queue is deprecated and will be removed in Redis 5.0.0. Use Redis#pipelined instead." \
-      "(called from: #{caller(1, 1).first})"
-    )
-
-    synchronize do
-      @queue[Thread.current.object_id] << command
-    end
-  end
-
-  # @deprecated Sends all commands in the queue.
-  #
-  # See http://redis.io/topics/pipelining for more details.
-  #
-  def commit
-    ::Redis.deprecate!(
-      "Redis#commit is deprecated and will be removed in Redis 5.0.0. Use Redis#pipelined instead. " \
-      "(called from: #{Kernel.caller(1, 1).first})"
-    )
-
-    synchronize do |client|
-      begin
-        pipeline = Pipeline.new(client)
-        @queue[Thread.current.object_id].each do |command|
-          pipeline.call(command)
-        end
-
-        client.call_pipelined(pipeline)
-      ensure
-        @queue.delete(Thread.current.object_id)
-      end
-    end
-  end
-
   def _client
     @client
   end

test/redis/client_test.rb

@@ -26,38 +26,6 @@ def test_call_raise
     end
   end
 
-  def test_queue_commit
-    r.queue("SET", "foo", "bar")
-    r.queue("GET", "foo")
-    result = r.commit
-
-    assert_equal result, ["OK", "bar"]
-  end
-
-  def test_commit_raise
-    r.queue("SET", "foo", "bar")
-    r.queue("INCR")
-
-    assert_raises(Redis::CommandError) do
-      r.commit
-    end
-  end
-
-  def test_queue_after_error
-    r.queue("SET", "foo", "bar")
-    r.queue("INCR")
-
-    assert_raises(Redis::CommandError) do
-      r.commit
-    end
-
-    r.queue("SET",  "foo", "bar")
-    r.queue("INCR", "baz")
-    result = r.commit
-
-    assert_equal result, ["OK", 1]
-  end
-
   def test_client_with_custom_connector
     custom_connector = Class.new(Redis::Client::Connector) do
       def resolve

test/redis/thread_safety_test.rb

@@ -27,35 +27,5 @@ def test_thread_safety
       assert_equal ["1"], @foos.uniq
       assert_equal ["2"], @bars.uniq
     end
-
-    def test_thread_safety_queue_commit
-      redis = Redis.new(OPTIONS)
-      redis.set "foo", 1
-      redis.set "bar", 2
-
-      sample = 100
-
-      t1 = Thread.new do
-        sample.times do
-          r.queue("get", "foo")
-        end
-
-        @foos = r.commit
-      end
-
-      t2 = Thread.new do
-        sample.times do
-          r.queue("get", "bar")
-        end
-
-        @bars = r.commit
-      end
-
-      t1.join
-      t2.join
-
-      assert_equal ["1"], @foos.uniq
-      assert_equal ["2"], @bars.uniq
-    end
   end
 end