Skip to content

Commit 45ccba4

Browse files
committed
Simplify test.
As suggested by @beedub.
1 parent 39944a9 commit 45ccba4

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

test/internals_test.rb

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -162,25 +162,14 @@ def test_connection_timeout
162162

163163
driver(:ruby) do
164164
def test_write_timeout
165-
t = Thread.new do
166-
TCPServer.new("127.0.0.1", 6383)
167-
end
168-
169-
begin
170-
TCPSocket.new("127.0.0.1", 6383)
171-
rescue Errno::ECONNREFUSED
172-
sleep(0.05)
173-
retry
174-
end
165+
TCPServer.new("127.0.0.1", 6383)
175166

176167
assert_raise(Redis::TimeoutError) do
177168
Timeout.timeout(1) do
178169
redis = Redis.new(:port => 6383, :timeout => 5, :write_timeout => 0.2)
179170
redis.set("foo", "1" * 1048576)
180171
end
181172
end
182-
ensure
183-
t.join if t
184173
end
185174
end
186175

0 commit comments

Comments
 (0)