Skip to content

Commit 5d5252d

Browse files
authored
Merge pull request #1218 from casperisfine/test-redis-7.2
Add Redis server 7.2 to the CI matrix
2 parents 9518dab + 63581a9 commit 5d5252d

File tree

4 files changed

+6
-32
lines changed

4 files changed

+6
-32
lines changed

.github/workflows/test.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
runs-on: ubuntu-latest
3838
env:
3939
LOW_TIMEOUT: "0.01"
40-
REDIS_BRANCH: "7.0"
40+
REDIS_BRANCH: "7.2"
4141
steps:
4242
- name: Check out code
4343
uses: actions/checkout@v3
@@ -74,7 +74,7 @@ jobs:
7474
runs-on: ubuntu-latest
7575
env:
7676
LOW_TIMEOUT: "0.01"
77-
REDIS_BRANCH: "7.0"
77+
REDIS_BRANCH: "7.2"
7878
TRUFFLERUBYOPT: "--engine.Mode=latency"
7979
steps:
8080
- name: Check out code
@@ -113,7 +113,7 @@ jobs:
113113
env:
114114
LOW_TIMEOUT: "0.01"
115115
DRIVER: ${{ matrix.driver }}
116-
REDIS_BRANCH: "7.0"
116+
REDIS_BRANCH: "7.2"
117117
steps:
118118
- name: Check out code
119119
uses: actions/checkout@v3
@@ -146,7 +146,7 @@ jobs:
146146
strategy:
147147
fail-fast: false
148148
matrix:
149-
redis: ["6.2", "6.0", "5.0"]
149+
redis: ["7.0", "6.2", "6.0", "5.0"]
150150
runs-on: ubuntu-latest
151151
env:
152152
LOW_TIMEOUT: "0.14"

makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
REDIS_BRANCH ?= 7.0
1+
REDIS_BRANCH ?= 7.2
22
ROOT_DIR :=$(shell dirname $(realpath $(firstword $(MAKEFILE_LIST))))
33
TMP := tmp
44
CONF := ${ROOT_DIR}/test/support/conf/redis-${REDIS_BRANCH}.conf

test/redis/remote_server_control_commands_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def test_object
7575

7676
assert_equal 1, r.object(:refcount, "list")
7777
encoding = r.object(:encoding, "list")
78-
assert encoding == "ziplist" || encoding == "quicklist", "Wrong encoding for list"
78+
assert encoding == "ziplist" || encoding == "quicklist" || encoding == "listpack", "Wrong encoding for list"
7979
assert r.object(:idletime, "list").is_a?(Integer)
8080
end
8181

test/redis/scanning_test.rb

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -127,32 +127,6 @@ def test_scan_each_block_match
127127
assert all_keys.sort == keys_from_scan.uniq.sort
128128
end
129129

130-
def test_sscan_with_encoding
131-
%i[intset hashtable].each do |enc|
132-
r.del "set"
133-
134-
prefix = ""
135-
prefix = "ele:" if enc == :hashtable
136-
137-
elements = []
138-
100.times { |j| elements << "#{prefix}#{j}" }
139-
140-
r.sadd "set", elements
141-
142-
assert_equal enc.to_s, r.object("encoding", "set")
143-
144-
cursor = 0
145-
all_keys = []
146-
loop do
147-
cursor, keys = r.sscan "set", cursor
148-
all_keys += keys
149-
break if cursor == "0"
150-
end
151-
152-
assert_equal 100, all_keys.uniq.size
153-
end
154-
end
155-
156130
def test_sscan_each_enumerator
157131
elements = []
158132
100.times { |j| elements << "ele:#{j}" }

0 commit comments

Comments
 (0)