Skip to content

Commit 9c808aa

Browse files
committed
Remove some TODOs
1 parent 6ff3f67 commit 9c808aa

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

test/redis/blocking_commands_test.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ def test_brpoplpush_disable_client_timeout
4646
end
4747

4848
def test_brpoplpush_in_transaction
49-
# TODO: redis-client transactions don't support blocking calls.
5049
results = r.multi do |transaction|
5150
transaction.brpoplpush('foo', 'bar')
5251
transaction.brpoplpush('foo', 'bar', timeout: 2)

test/redis/internals_test.rb

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -155,19 +155,6 @@ def test_retry_pipeline_first_command
155155
end
156156
end
157157

158-
def test_don_t_retry_when_second_read_in_pipeline_raises_econnreset
159-
skip("TODO: decide if this is really worth it")
160-
close_on_ping([1]) do |redis|
161-
assert_raises Redis::ConnectionError do
162-
redis.pipelined do |pipeline|
163-
pipeline.ping
164-
pipeline.ping # Second #read times out
165-
end
166-
end
167-
refute_predicate redis._client, :connected?
168-
end
169-
end
170-
171158
def close_on_connection(seq, &block)
172159
@n = 0
173160

0 commit comments

Comments
 (0)