Skip to content

Commit aa594a4

Browse files
committed
Fix broken expire tests
1 parent a48d002 commit aa594a4

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

lib/redis/distributed.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,13 @@ def persist(key)
115115
end
116116

117117
# Set a key's time to live in seconds.
118-
def expire(key, seconds)
119-
node_for(key).expire(key, seconds)
118+
def expire(key, seconds, **kwargs)
119+
node_for(key).expire(key, seconds, **kwargs)
120120
end
121121

122122
# Set the expiration for a key as a UNIX timestamp.
123-
def expireat(key, unix_time)
124-
node_for(key).expireat(key, unix_time)
123+
def expireat(key, unix_time, **kwargs)
124+
node_for(key).expireat(key, unix_time, **kwargs)
125125
end
126126

127127
# Get the time to live (in seconds) for a key.
@@ -130,13 +130,13 @@ def ttl(key)
130130
end
131131

132132
# Set a key's time to live in milliseconds.
133-
def pexpire(key, milliseconds)
134-
node_for(key).pexpire(key, milliseconds)
133+
def pexpire(key, milliseconds, **kwarg)
134+
node_for(key).pexpire(key, milliseconds, **kwarg)
135135
end
136136

137137
# Set the expiration for a key as number of milliseconds from UNIX Epoch.
138-
def pexpireat(key, ms_unix_time)
139-
node_for(key).pexpireat(key, ms_unix_time)
138+
def pexpireat(key, ms_unix_time, **kwarg)
139+
node_for(key).pexpireat(key, ms_unix_time, **kwarg)
140140
end
141141

142142
# Get the time to live (in milliseconds) for a key.

test/lint/value_types.rb

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -111,16 +111,16 @@ def test_expireat
111111

112112
target_version "7.0.0" do
113113
r.set("bar", "s2")
114-
refute r.expire_at("bar", (Time.now + 5).to_i, xx: true)
115-
assert r.expire_at("bar", (Time.now + 5).to_i, nx: true)
116-
refute r.expire_at("bar", (Time.now + 5).to_i, nx: true)
117-
assert r.expire_at("bar", (Time.now + 5).to_i, xx: true)
118-
119-
r.expire_at("bar", 10)
120-
refute r.expire_at("bar", (Time.now + 15).to_i, lt: true)
121-
refute r.expire_at("bar", (Time.now + 5).to_i, gt: true)
122-
assert r.expire_at("bar", (Time.now + 15).to_i, gt: true)
123-
assert r.expire_at("bar", (Time.now + 5).to_i, lt: true)
114+
refute r.expireat("bar", (Time.now + 5).to_i, xx: true)
115+
assert r.expireat("bar", (Time.now + 5).to_i, nx: true)
116+
refute r.expireat("bar", (Time.now + 5).to_i, nx: true)
117+
assert r.expireat("bar", (Time.now + 5).to_i, xx: true)
118+
119+
r.expireat("bar", (Time.now + 10).to_i)
120+
refute r.expireat("bar", (Time.now + 15).to_i, lt: true)
121+
refute r.expireat("bar", (Time.now + 5).to_i, gt: true)
122+
assert r.expireat("bar", (Time.now + 15).to_i, gt: true)
123+
assert r.expireat("bar", (Time.now + 5).to_i, lt: true)
124124
end
125125
end
126126

@@ -133,16 +133,16 @@ def test_pexpireat
133133

134134
target_version "7.0.0" do
135135
r.set("bar", "s2")
136-
refute r.expire_at("bar", (Time.now + 5).to_i * 1_000, xx: true)
137-
assert r.expire_at("bar", (Time.now + 5).to_i * 1_000, nx: true)
138-
refute r.expire_at("bar", (Time.now + 5).to_i * 1_000, nx: true)
139-
assert r.expire_at("bar", (Time.now + 5).to_i * 1_000, xx: true)
140-
141-
r.expire_at("bar", 10)
142-
refute r.expire_at("bar", (Time.now + 15).to_i * 1_000, lt: true)
143-
refute r.expire_at("bar", (Time.now + 5).to_i * 1_000, gt: true)
144-
assert r.expire_at("bar", (Time.now + 15).to_i * 1_000, gt: true)
145-
assert r.expire_at("bar", (Time.now + 5).to_i * 1_000, lt: true)
136+
refute r.pexpireat("bar", (Time.now + 5).to_i * 1_000, xx: true)
137+
assert r.pexpireat("bar", (Time.now + 5).to_i * 1_000, nx: true)
138+
refute r.pexpireat("bar", (Time.now + 5).to_i * 1_000, nx: true)
139+
assert r.pexpireat("bar", (Time.now + 5).to_i * 1_000, xx: true)
140+
141+
r.pexpireat("bar", (Time.now + 10).to_i * 1_000)
142+
refute r.pexpireat("bar", (Time.now + 15).to_i * 1_000, lt: true)
143+
refute r.pexpireat("bar", (Time.now + 5).to_i * 1_000, gt: true)
144+
assert r.pexpireat("bar", (Time.now + 15).to_i * 1_000, gt: true)
145+
assert r.pexpireat("bar", (Time.now + 5).to_i * 1_000, lt: true)
146146
end
147147
end
148148

0 commit comments

Comments
 (0)