Skip to content

Commit e07a66e

Browse files
authored
Revert "Remove error caused by hiredis ssl not supported"
1 parent ce3f301 commit e07a66e

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

lib/redis/connection/hiredis.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ def self.connect(config)
1515

1616
if config[:scheme] == "unix"
1717
connection.connect_unix(config[:path], connect_timeout)
18+
elsif config[:scheme] == "rediss" || config[:ssl]
19+
raise NotImplementedError, "SSL not supported by hiredis driver"
1820
else
1921
connection.connect(config[:host], config[:port], connect_timeout)
2022
end

test/ssl_test.rb

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,17 @@ def test_ssl_blocking
4646
end
4747
end
4848

49+
driver(:hiredis, :synchrony) do
50+
def test_ssl_not_implemented_exception
51+
assert_raises(NotImplementedError) do
52+
RedisMock.start({ ping: proc { "+PONG" } }, ssl_server_opts("trusted")) do |port|
53+
redis = Redis.new(port: port, ssl: true, ssl_params: { ca_file: ssl_ca_file })
54+
redis.ping
55+
end
56+
end
57+
end
58+
end
59+
4960
private
5061

5162
def ssl_server_opts(prefix)

0 commit comments

Comments
 (0)