Commit 0160ce9
committed
perf: remove proactive module validation to reduce network calls (#370)
Remove MODULE LIST calls during connection initialization and index
creation. Operations now fail naturally when Redis modules are missing,
providing clear error messages at the point of failure.
Changes:
- Remove validate_modules() function and DEFAULT_REQUIRED_MODULES constant
- Remove required_modules parameter from all connection methods
- Remove proactive validation from SearchIndex and AsyncSearchIndex
- Remove validation from SemanticRouter.from_existing()
- Fix SemanticCache to use lazy client initialization
- Remove skip_if_module_version_error test helper
- Remove unused RedisModuleVersionError exception
- Add RediSearch module availability checks to skip tests when module not present
- Fix mocking strategy to patch instance methods instead of class methods
- Handle different Redis versions (6.2.6-v9, latest, 8.0.2) in CI environment
- Ensure tests work with both testcontainers (local) and provided Redis (CI)
- Ensures compatibility across different Redis Stack versions
- Support Redis 6.2.6-v9 returns 'dims' while other versions may return 'dim'.
- Handle multiple field name variations for vector attributes
- Support 'distance_metric' and 'metric' field names
- Support 'data_type', 'type', and 'datatype' field variations
- Safely handle missing or renamed fields across Redis versions
This ensures compatibility with Redis 6.2.6-v9 which may return
different field names compared to newer Redis Stack versions.1 parent b32ed95 commit 0160ce9
File tree
13 files changed
+534
-253
lines changed- redisvl
- extensions
- cache/llm
- router
- index
- redis
- tests
- integration
13 files changed
+534
-253
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | 14 | | |
21 | 15 | | |
22 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
118 | 117 | | |
119 | 118 | | |
120 | 119 | | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
132 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
133 | 128 | | |
134 | 129 | | |
135 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | 70 | | |
72 | 71 | | |
73 | 72 | | |
| |||
439 | 438 | | |
440 | 439 | | |
441 | 440 | | |
442 | | - | |
443 | 441 | | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
458 | 446 | | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
459 | 450 | | |
460 | 451 | | |
461 | 452 | | |
| |||
481 | 472 | | |
482 | 473 | | |
483 | 474 | | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
484 | 479 | | |
485 | 480 | | |
486 | | - | |
| 481 | + | |
487 | 482 | | |
488 | | - | |
| 483 | + | |
| 484 | + | |
489 | 485 | | |
490 | 486 | | |
491 | 487 | | |
| |||
1193 | 1189 | | |
1194 | 1190 | | |
1195 | 1191 | | |
1196 | | - | |
1197 | | - | |
1198 | | - | |
1199 | | - | |
1200 | | - | |
1201 | | - | |
1202 | | - | |
1203 | | - | |
1204 | | - | |
1205 | | - | |
1206 | | - | |
1207 | | - | |
1208 | | - | |
1209 | | - | |
1210 | | - | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
1211 | 1200 | | |
1212 | 1201 | | |
1213 | 1202 | | |
| |||
1256 | 1245 | | |
1257 | 1246 | | |
1258 | 1247 | | |
1259 | | - | |
| 1248 | + | |
| 1249 | + | |
1260 | 1250 | | |
1261 | 1251 | | |
| 1252 | + | |
| 1253 | + | |
1262 | 1254 | | |
1263 | 1255 | | |
1264 | 1256 | | |
1265 | | - | |
| 1257 | + | |
| 1258 | + | |
1266 | 1259 | | |
1267 | 1260 | | |
1268 | 1261 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
| |||
93 | 92 | | |
94 | 93 | | |
95 | 94 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
100 | 122 | | |
101 | 123 | | |
102 | 124 | | |
| |||
155 | 177 | | |
156 | 178 | | |
157 | 179 | | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | 180 | | |
193 | 181 | | |
194 | 182 | | |
| |||
232 | 220 | | |
233 | 221 | | |
234 | 222 | | |
235 | | - | |
236 | 223 | | |
237 | 224 | | |
238 | 225 | | |
239 | 226 | | |
240 | 227 | | |
241 | 228 | | |
242 | 229 | | |
243 | | - | |
244 | | - | |
245 | 230 | | |
246 | 231 | | |
247 | 232 | | |
| |||
251 | 236 | | |
252 | 237 | | |
253 | 238 | | |
254 | | - | |
255 | 239 | | |
256 | 240 | | |
257 | 241 | | |
258 | 242 | | |
259 | 243 | | |
260 | 244 | | |
261 | | - | |
262 | | - | |
263 | | - | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
264 | 254 | | |
265 | 255 | | |
266 | 256 | | |
267 | 257 | | |
268 | 258 | | |
269 | | - | |
270 | 259 | | |
271 | 260 | | |
272 | 261 | | |
| |||
277 | 266 | | |
278 | 267 | | |
279 | 268 | | |
280 | | - | |
281 | | - | |
282 | 269 | | |
283 | 270 | | |
284 | 271 | | |
| |||
288 | 275 | | |
289 | 276 | | |
290 | 277 | | |
291 | | - | |
292 | 278 | | |
293 | 279 | | |
294 | 280 | | |
| |||
297 | 283 | | |
298 | 284 | | |
299 | 285 | | |
300 | | - | |
301 | | - | |
302 | | - | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
303 | 295 | | |
304 | 296 | | |
305 | 297 | | |
| |||
386 | 378 | | |
387 | 379 | | |
388 | 380 | | |
389 | | - | |
390 | 381 | | |
391 | | - | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
392 | 387 | | |
393 | 388 | | |
394 | 389 | | |
| |||
404 | 399 | | |
405 | 400 | | |
406 | 401 | | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
| 402 | + | |
412 | 403 | | |
413 | 404 | | |
414 | 405 | | |
415 | 406 | | |
416 | 407 | | |
417 | | - | |
418 | 408 | | |
419 | | - | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
420 | 414 | | |
421 | 415 | | |
422 | 416 | | |
| |||
427 | 421 | | |
428 | 422 | | |
429 | 423 | | |
430 | | - | |
431 | 424 | | |
432 | 425 | | |
433 | 426 | | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
| 427 | + | |
0 commit comments