Skip to content

Commit 35c2277

Browse files
committed
finish the job on module variable shuffling
1 parent 33cf7c5 commit 35c2277

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

redisvl/index/index.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -418,11 +418,7 @@ def set_client(self, redis_client: redis.Redis, **kwargs):
418418
index.set_client(client)
419419
420420
"""
421-
# TODO: Including required modules to match existing behavior, but we
422-
# need to review.
423-
RedisConnectionFactory.validate_sync_redis(
424-
redis_client, required_modules=self.required_modules
425-
)
421+
RedisConnectionFactory.validate_sync_redis(redis_client)
426422
self.__redis_client = redis_client
427423
return self
428424

@@ -931,8 +927,6 @@ async def connect(self, redis_url: Optional[str] = None, **kwargs):
931927
"connect() is deprecated; pass connection parameters in __init__",
932928
DeprecationWarning,
933929
)
934-
# TODO: Intentionally not including required modules to match existing
935-
# behavior, but we need to review.
936930
client = await RedisConnectionFactory._get_aredis_connection(
937931
redis_url=redis_url, **kwargs
938932
)
@@ -960,8 +954,6 @@ async def _get_client(self) -> aredis.Redis:
960954
if self._redis_url:
961955
kwargs["url"] = self._redis_url
962956
self._redis_client = (
963-
# TODO: Intentionally not including required modules to match existing
964-
# behavior, but we need to review.
965957
await RedisConnectionFactory._get_aredis_connection(**kwargs)
966958
)
967959
await RedisConnectionFactory.validate_async_redis(

0 commit comments

Comments
 (0)