refactor: address Copilot review suggestions

- Extract duplicated condition check into _should_warn_for_async_only() helper method
- Add pytest autouse fixture to reset warning flag before each test
- Improves code maintainability and test isolation

Co-authored-by: GitHub Copilot <[email protected]>

Author: bsbodden

redisvl/extensions/cache/embeddings/embeddings.py

@@ -126,6 +126,14 @@ def _process_cache_data(
         cache_hit = CacheEntry(**convert_bytes(data))
         return cache_hit.model_dump(exclude_none=True)
 
+    def _should_warn_for_async_only(self) -> bool:
+        """Check if warning should be shown for async-only client usage.
+
+        Returns:
+            bool: True if only async client is available and warning hasn't been shown.
+        """
+        return self._owns_redis_client is False and self._redis_client is None
+
     def get(
         self,
         text: str,
@@ -169,7 +177,7 @@ def get_by_key(self, key: str) -> Optional[Dict[str, Any]]:
 
             embedding_data = cache.get_by_key("embedcache:1234567890abcdef")
         """
-        if self._owns_redis_client is False and self._redis_client is None:
+        if self._should_warn_for_async_only():
             if not EmbeddingsCache._warning_shown:
                 logger.warning(
                     "EmbeddingsCache initialized with async_redis_client only. "
@@ -212,7 +220,7 @@ def mget_by_keys(self, keys: List[str]) -> List[Optional[Dict[str, Any]]]:
         if not keys:
             return []
 
-        if self._owns_redis_client is False and self._redis_client is None:
+        if self._should_warn_for_async_only():
             if not EmbeddingsCache._warning_shown:
                 logger.warning(
                     "EmbeddingsCache initialized with async_redis_client only. "
@@ -301,7 +309,7 @@ def set(
             text, model_name, embedding, metadata
         )
 
-        if self._owns_redis_client is False and self._redis_client is None:
+        if self._should_warn_for_async_only():
             if not EmbeddingsCache._warning_shown:
                 logger.warning(
                     "EmbeddingsCache initialized with async_redis_client only. "
@@ -359,7 +367,7 @@ def mset(
         if not items:
             return []
 
-        if self._owns_redis_client is False and self._redis_client is None:
+        if self._should_warn_for_async_only():
             if not EmbeddingsCache._warning_shown:
                 logger.warning(
                     "EmbeddingsCache initialized with async_redis_client only. "

tests/integration/test_embedcache_warnings.py

@@ -9,12 +9,18 @@
 from redisvl.extensions.cache.embeddings import EmbeddingsCache
 
 
+@pytest.fixture(autouse=True)
+def reset_warning_flag():
+    """Reset the warning flag before each test to ensure test isolation."""
+    EmbeddingsCache._warning_shown = False
+    yield
+    # Optionally reset after test as well for cleanup
+    EmbeddingsCache._warning_shown = False
+
+
 @pytest.mark.asyncio
 async def test_sync_methods_warn_with_async_only_client(async_client, caplog):
     """Test that sync methods warn when only async client is provided."""
-    # Reset the warning flag for testing
-    EmbeddingsCache._warning_shown = False
-
     # Initialize EmbeddingsCache with only async_redis_client
     cache = EmbeddingsCache(name="test_cache", async_redis_client=async_client)
 
@@ -49,9 +55,6 @@ async def test_sync_methods_warn_with_async_only_client(async_client, caplog):
 
 def test_no_warning_with_sync_client(redis_url):
     """Test that no warning is shown when sync client is provided."""
-    # Reset the warning flag for testing
-    EmbeddingsCache._warning_shown = False
-
     # Create sync redis client from redis_url
     sync_client = Redis.from_url(redis_url)
 
@@ -73,9 +76,6 @@ def test_no_warning_with_sync_client(redis_url):
 @pytest.mark.asyncio
 async def test_async_methods_no_warning(async_client):
     """Test that async methods don't trigger warnings."""
-    # Reset the warning flag for testing
-    EmbeddingsCache._warning_shown = False
-
     # Initialize EmbeddingsCache with only async_redis_client
     cache = EmbeddingsCache(name="test_cache", async_redis_client=async_client)