Skip to content

Commit 8f8642f

Browse files
committed
Scale back module validation to match existing behavior
1 parent aaa2091 commit 8f8642f

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

redisvl/index/index.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -391,8 +391,10 @@ def connect(self, redis_url: Optional[str] = None, **kwargs):
391391
index.connect(redis_url="redis://localhost:6379")
392392
393393
"""
394+
# TODO: Intentionally not including required modules to match existing
395+
# behavior, but we need to review.
394396
self.__redis_client = RedisConnectionFactory.get_redis_connection(
395-
redis_url=redis_url, required_modules=self.required_modules, **kwargs
397+
redis_url=redis_url, **kwargs
396398
)
397399

398400
@deprecated_function("set_client", "Pass connection parameters in __init__.")
@@ -420,6 +422,8 @@ def set_client(self, redis_client: redis.Redis, **kwargs):
420422
index.set_client(client)
421423
422424
"""
425+
# TODO: Including required modules to match existing behavior, but we
426+
# need to review.
423427
RedisConnectionFactory.validate_sync_redis(
424428
redis_client, required_modules=self.required_modules
425429
)
@@ -934,8 +938,10 @@ async def connect(self, redis_url: Optional[str] = None, **kwargs):
934938
"connect() is deprecated; pass connection parameters in __init__",
935939
DeprecationWarning,
936940
)
941+
# TODO: Intentionally not including required modules to match existing
942+
# behavior, but we need to review.
937943
client = await RedisConnectionFactory._get_aredis_connection(
938-
redis_url=redis_url, required_modules=self.required_modules, **kwargs
944+
redis_url=redis_url, **kwargs
939945
)
940946
await self.set_client(client)
941947

@@ -961,9 +967,9 @@ async def _get_client(self) -> aredis.Redis:
961967
if self._redis_url:
962968
kwargs["url"] = self._redis_url
963969
self._redis_client = (
964-
await RedisConnectionFactory._get_aredis_connection(
965-
required_modules=self.required_modules, **kwargs
966-
)
970+
# TODO: Intentionally not including required modules to match existing
971+
# behavior, but we need to review.
972+
await RedisConnectionFactory._get_aredis_connection(**kwargs)
967973
)
968974
await RedisConnectionFactory.validate_async_redis(
969975
self._redis_client, self._lib_name

0 commit comments

Comments
 (0)