Skip to content

Commit c6464ac

Browse files
committed
Update logger interference test to check for multiple log emission
1 parent fdb9454 commit c6464ac

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

tests/unit/logger_interference_checker.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@
99
)
1010
)
1111

12-
# Configure root logger
13-
root_logger = logging.getLogger()
14-
root_logger.handlers = [handler]
15-
root_logger.setLevel(logging.INFO)
16-
1712
# Log before import
1813
app_logger = logging.getLogger("app")
14+
app_logger.setLevel(logging.INFO)
15+
app_logger.addHandler(handler)
1916
app_logger.info("PRE_IMPORT_FORMAT")
2017

2118
# Import RedisVL

tests/unit/test_utils.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -489,18 +489,22 @@ def test_logging_configuration_not_overridden(self):
489489

490490
# Extract the log lines
491491
output_lines = result.stdout.strip().split("\n")
492-
pre_import_line = ""
493-
post_import_line = ""
492+
pre_import_lines = []
493+
post_import_lines = []
494494

495495
for line in output_lines:
496496
if "PRE_IMPORT_FORMAT" in line:
497-
pre_import_line = line
497+
pre_import_lines.append(line)
498498
elif "POST_IMPORT_FORMAT" in line:
499-
post_import_line = line
499+
post_import_lines.append(line)
500500

501501
# Check if we found both lines
502-
assert pre_import_line, "No pre-import log message found"
503-
assert post_import_line, "No post-import log message found"
502+
assert pre_import_lines, "No pre-import log message(s) found"
503+
assert post_import_lines, "No post-import log message(s) found"
504+
assert len(pre_import_lines) == 1, "Multiple pre-import log messages found"
505+
assert len(post_import_lines) == 1, "Multiple post-import log messages found"
506+
pre_import_line = pre_import_lines[0]
507+
post_import_line = post_import_lines[0]
504508

505509
# Print for debugging
506510
print(f"Pre-import format: {pre_import_line}")

0 commit comments

Comments
 (0)