Lint passes

Author: Nitin Kanukolanu

redisvl/redis/connection.py

@@ -145,8 +145,8 @@ def check_vector_capabilities(client: SyncRedisClient) -> VectorSupport:
     Returns:
         VectorSupport with version info and supported features
     """
-    info = client.info("server")
-    redis_version = info.get("redis_version", "0.0.0")
+    info = client.info("server")  # type: ignore[union-attr]
+    redis_version = info.get("redis_version", "0.0.0")  # type: ignore[union-attr]
 
     modules = RedisConnectionFactory.get_modules(client)
     search_ver = modules.get("search", 0)
@@ -173,8 +173,8 @@ async def check_vector_capabilities_async(client: AsyncRedisClient) -> VectorSup
     Returns:
         VectorSupport with version info and supported features
     """
-    info = await client.info("server")
-    redis_version = info.get("redis_version", "0.0.0")
+    info = await client.info("server")  # type: ignore[union-attr]
+    redis_version = info.get("redis_version", "0.0.0")  # type: ignore[union-attr]
 
     modules = await RedisConnectionFactory.get_modules_async(client)
     search_ver = modules.get("search", 0)
@@ -192,66 +192,6 @@ async def check_vector_capabilities_async(client: AsyncRedisClient) -> VectorSup
     )
 
 
-def supports_svs_vamana(client: SyncRedisClient) -> bool:
-    """Check if Redis server supports SVS-VAMANA algorithm.
-
-    SVS-Vamana requires:
-    - Redis version >= 8.2.0
-    - RediSearch version >= 2.8.10 (20810)
-
-    Args:
-        client: Sync Redis client instance
-
-    Returns:
-        bool: True if SVS-VAMANA is supported, False otherwise
-    """
-    info = client.info()
-    redis_version = info.get("redis_version", "0.0.0")
-    if not compare_versions(redis_version, SVS_MIN_REDIS_VERSION):
-        return False
-
-    # Check module versions
-    modules = unpack_redis_modules(convert_bytes(client.module_list()))
-    for module in SVS_REQUIRED_MODULES:
-        module_name = module["name"]
-        required_version = module["ver"]
-        if module_name not in modules:
-            return False
-        if modules[module_name] < required_version:
-            return False
-    return True
-
-
-async def async_supports_svs_vamana(client: AsyncRedisClient) -> bool:
-    """Check if Redis server supports SVS-VAMANA algorithm asynchronously.
-
-    SVS-Vamana requires:
-    - Redis version >= 8.2.0
-    - RediSearch version >= 2.8.10 (20810)
-
-    Args:
-        client: Sync Redis client instance
-
-    Returns:
-        bool: True if SVS-VAMANA is supported, False otherwise
-    """
-    info = await client.info()
-    redis_version = info.get("redis_version", "0.0.0")
-    if not compare_versions(redis_version, SVS_MIN_REDIS_VERSION):
-        return False
-
-    # Check module versions
-    modules = unpack_redis_modules(convert_bytes(await client.module_list()))
-    for module in SVS_REQUIRED_MODULES:
-        module_name = module["name"]
-        required_version = module["ver"]
-        if module_name not in modules:
-            return False
-        if modules[module_name] < required_version:
-            return False
-    return True
-
-
 def get_address_from_env() -> str:
     """Get Redis URL from environment variable."""
     redis_url = os.getenv(REDIS_URL_ENV_VAR)
@@ -558,6 +498,7 @@ async def _get_aredis_connection(
         """
         url = url or get_address_from_env()
 
+        client: AsyncRedisClient
         if url.startswith("redis+sentinel"):
             client = RedisConnectionFactory._redis_sentinel_client(
                 url, AsyncRedis, **kwargs

tests/unit/test_fields.py

@@ -448,9 +448,6 @@ def test_field_factory_with_new_attributes():
     assert vector_field.attrs.index_missing == True
 
 
-# ==================== SVS-VAMANA TESTS ====================
-
-
 def test_svs_vector_field_creation():
     """Test basic SVS-VAMANA vector field creation."""
     svs_field = create_svs_vector_field()
@@ -643,9 +640,6 @@ def test_svs_vector_field_leanvec8x8_with_reduce():
     assert redis_field.args[redis_field.args.index("REDUCE") + 1] == 512
 
 
-# ==================== SVS-VAMANA INDEX VALIDATION TESTS ====================
-
-
 def test_uses_svs_vamana_true():
     """Test _uses_svs_vamana returns True for SVS schema."""
     schema_dict = {

tests/unit/test_svs_capability_detection.py

@@ -12,18 +12,12 @@
 from redisvl.exceptions import RedisModuleVersionError
 from redisvl.redis.connection import (
     VectorSupport,
-    async_supports_svs_vamana,
     check_vector_capabilities,
     check_vector_capabilities_async,
     compare_versions,
     format_module_version,
-    supports_svs_vamana,
 )
 
-# ============================================================================
-# Helper Function Tests
-# ============================================================================
-
 
 def test_format_version_20810():
     """Test formatting version 20810 -> 2.8.10"""
@@ -44,11 +38,6 @@ def test_compare_lesser_version():
     assert compare_versions("8.2.0", "8.2.1") is False
 
 
-# ============================================================================
-# check_vector_capabilities Tests
-# ============================================================================
-
-
 def test_check_vector_capabilities_supported():
     """Test check_vector_capabilities when SVS is supported."""
     mock_client = Mock()
@@ -118,47 +107,6 @@ async def test_check_vector_capabilities_async_supported():
         assert caps.svs_vamana_supported is True
 
 
-# ============================================================================
-# supports_svs_vamana Tests
-# ============================================================================
-
-
-def test_supports_svs_vamana_true():
-    """Test supports_svs_vamana returns True when supported."""
-    mock_client = Mock()
-    mock_client.info.return_value = {"redis_version": "8.2.0"}
-    mock_client.module_list.return_value = [
-        {"name": b"search", "ver": 20810},
-        {"name": b"searchlight", "ver": 20810},
-    ]
-
-    assert supports_svs_vamana(mock_client) is True
-
-
-def test_supports_svs_vamana_false_old_redis():
-    """Test supports_svs_vamana returns False with old Redis."""
-    mock_client = Mock()
-    mock_client.info.return_value = {"redis_version": "7.2.4"}
-    mock_client.module_list.return_value = [
-        {"name": b"search", "ver": 20810},
-    ]
-
-    assert supports_svs_vamana(mock_client) is False
-
-
-def test_supports_svs_vamana_exception_handling():
-    """Test supports_svs_vamana handles exceptions gracefully."""
-    mock_client = Mock()
-    mock_client.info.side_effect = Exception("Connection error")
-
-    assert supports_svs_vamana(mock_client) is False
-
-
-# ============================================================================
-# Exception Tests
-# ============================================================================
-
-
 def test_for_svs_vamana_error_message():
     """Test RedisModuleVersionError.for_svs_vamana creates proper exception."""
     caps = VectorSupport(