Skip to content

Commit de1ede1

Browse files
committed
fix url pass
1 parent db17aef commit de1ede1

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

redisvl/index/index.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ def _redis_client(self) -> Optional[redis.Redis]:
358358
with self._lock:
359359
if self.__redis_client is None:
360360
self.__redis_client = RedisConnectionFactory.get_redis_connection(
361-
url=self._redis_url,
361+
redis_url=self._redis_url,
362362
**self._connection_kwargs,
363363
)
364364
return self.__redis_client

redisvl/redis/connection.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def connect(
223223

224224
@staticmethod
225225
def get_redis_connection(
226-
url: Optional[str] = None,
226+
redis_url: Optional[str] = None,
227227
required_modules: Optional[List[Dict[str, Any]]] = None,
228228
**kwargs,
229229
) -> Redis:
@@ -245,7 +245,7 @@ def get_redis_connection(
245245
variable is not set.
246246
RedisModuleVersionError: If required Redis modules are not installed.
247247
"""
248-
url = url or get_address_from_env()
248+
url = redis_url or get_address_from_env()
249249
client = Redis.from_url(url, **kwargs)
250250

251251
RedisConnectionFactory.validate_sync_redis(

tests/integration/test_search_index.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,17 @@ def test_search_index_from_existing(client, index):
8484
assert index2.schema == index.schema
8585

8686

87+
def test_search_index_from_existing_url(redis_url, index):
88+
index.create(overwrite=True)
89+
90+
try:
91+
index2 = SearchIndex.from_existing(index.name, redis_url=redis_url)
92+
except Exception as e:
93+
pytest.skip(str(e))
94+
95+
assert index2.schema == index.schema
96+
97+
8798
def test_search_index_from_existing_complex(client):
8899
schema = {
89100
"index": {

0 commit comments

Comments
 (0)