Skip to content

Commit 3851dec

Browse files
committed
feat: change Z member type to string in rueidiscompat to align go-redis
1 parent d25943e commit 3851dec

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

rueidiscompat/adapter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1905,7 +1905,7 @@ func (c *Compat) zAddArgs(ctx context.Context, key string, incr bool, args ZAddA
19051905
cmd = cmd.Args("INCR")
19061906
}
19071907
for _, v := range args.Members {
1908-
cmd = cmd.Args(strconv.FormatFloat(v.Score, 'f', -1, 64), str(v.Member))
1908+
cmd = cmd.Args(strconv.FormatFloat(v.Score, 'f', -1, 64), v.Member)
19091909
}
19101910
resp := c.client.Do(ctx, cmd.Build())
19111911
return resp

rueidiscompat/adapter_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3612,28 +3612,28 @@ func testAdapter(resp3 bool) {
36123612
It("should ZAdd bytes", func() {
36133613
added, err := adapter.ZAdd(ctx, "zset", Z{
36143614
Score: 1,
3615-
Member: []byte("one"),
3615+
Member: "one",
36163616
}).Result()
36173617
Expect(err).NotTo(HaveOccurred())
36183618
Expect(added).To(Equal(int64(1)))
36193619

36203620
added, err = adapter.ZAdd(ctx, "zset", Z{
36213621
Score: 1,
3622-
Member: []byte("uno"),
3622+
Member: "uno",
36233623
}).Result()
36243624
Expect(err).NotTo(HaveOccurred())
36253625
Expect(added).To(Equal(int64(1)))
36263626

36273627
added, err = adapter.ZAdd(ctx, "zset", Z{
36283628
Score: 2,
3629-
Member: []byte("two"),
3629+
Member: "two",
36303630
}).Result()
36313631
Expect(err).NotTo(HaveOccurred())
36323632
Expect(added).To(Equal(int64(1)))
36333633

36343634
added, err = adapter.ZAdd(ctx, "zset", Z{
36353635
Score: 3,
3636-
Member: []byte("two"),
3636+
Member: "two",
36373637
}).Result()
36383638
Expect(err).NotTo(HaveOccurred())
36393639
Expect(added).To(Equal(int64(0)))

rueidiscompat/command.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1865,7 +1865,7 @@ func (cmd *XInfoConsumersCmd) Result() ([]XInfoConsumer, error) {
18651865

18661866
// Z represents sorted set member.
18671867
type Z struct {
1868-
Member any
1868+
Member string
18691869
Score float64
18701870
}
18711871

0 commit comments

Comments
 (0)