Reverts r21958 and r21959 (#1739).

git-svn-id: https://svn.redmine.org/redmine/trunk@21960 e93f8b46-1217-0410-a6f0-8f06a7374b81

Author: vividtone

app/helpers/issues_helper.rb

@@ -534,7 +534,7 @@ def show_detail(detail, no_html=false, options={})
         old_value = format_date(detail.old_value.to_date) if detail.old_value
 
       when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
-            'priority_id', 'category_id', 'fixed_version_id', 'author_id'
+            'priority_id', 'category_id', 'fixed_version_id'
         value = find_name_by_reflection(field, detail.value)
         old_value = find_name_by_reflection(field, detail.old_value)
 
@@ -778,23 +778,4 @@ def projects_for_select(issue)
       projects
     end
   end
-
-  def author_options_for_select(issue, project)
-    users = issue.assignable_users.select {|m| m.is_a?(User) && m.allowed_to?(:add_issues, project) }
-
-    if issue.new_record?
-      if users.include?(User.current)
-        principals_options_for_select(users, issue.author)
-      else
-        principals_options_for_select([User.current] + users)
-      end
-    elsif issue.persisted?
-      if users.include?(issue.author)
-        principals_options_for_select(users, issue.author)
-      else
-        author_principal = Principal.find(issue.author_id)
-        principals_options_for_select([author_principal] + users, author_principal)
-      end
-    end
-  end
 end

app/models/issue.rb

@@ -111,7 +111,6 @@ class Issue < ActiveRecord::Base
   before_validation :clear_disabled_fields
   before_save :close_duplicates, :update_done_ratio_from_issue_status,
               :force_updated_on_change, :update_closed_on
-  before_create :set_author_journal
   after_save do |issue|
     if !issue.saved_change_to_id? && issue.saved_change_to_project_id?
       issue.send :after_project_change
@@ -520,9 +519,6 @@ def estimated_hours=(h)
   safe_attributes(
     'deleted_attachment_ids',
     :if => lambda {|issue, user| issue.attachments_deletable?(user)})
-  safe_attributes(
-    'author_id',
-    :if => lambda {|issue, user| user.allowed_to?(:change_issue_author, issue.project)})
 
   def safe_attribute_names(user=nil)
     names = super
@@ -2024,14 +2020,6 @@ def create_parent_issue_journal
     end
   end
 
-  def set_author_journal
-    return unless new_record?
-    return unless self.author.present? && User.current.present? && self.author != User.current
-
-    self.init_journal(User.current)
-    self.current_journal.__send__(:add_attribute_detail, 'author_id', User.current.id, self.author.id)
-  end
-
   def send_notification
     if notify? && Setting.notified_events.include?('issue_added')
       Mailer.deliver_issue_add(self)

app/views/issues/_attributes.html.erb

@@ -3,9 +3,6 @@
 <div class="splitcontent">
 <div class="splitcontentleft">
 <% if @issue.safe_attribute?('status_id') && @allowed_statuses.present? %>
-<% if User.current.allowed_to?(:change_issue_author, @project) %>
-  <p><%= f.select :author_id, author_options_for_select(@issue, @project), :include_blank => false, :required => true %></p>
-<% end %>
 <p>
   <%= f.select :status_id, (@allowed_statuses.collect {|p| [p.name, p.id]}), {:required => true},
                 :onchange => "updateIssueFrom('#{escape_javascript(update_issue_form_path(@project, @issue))}', this)" %>

config/locales/ar.yml

@@ -1478,4 +1478,3 @@ ar:
     all references to them. This cannot be undone. Often, locking users instead of deleting
     them is the better solution.
   text_users_bulk_destroy_confirm: To confirm, please enter "%{yes}" below.
-  permission_change_issue_author: Change issue author

config/locales/az.yml

@@ -1570,4 +1570,3 @@ az:
     all references to them. This cannot be undone. Often, locking users instead of deleting
     them is the better solution.
   text_users_bulk_destroy_confirm: To confirm, please enter "%{yes}" below.
-  permission_change_issue_author: Change issue author

config/locales/bg.yml

@@ -1426,4 +1426,3 @@ bg:
     all references to them. This cannot be undone. Often, locking users instead of deleting
     them is the better solution.
   text_users_bulk_destroy_confirm: To confirm, please enter "%{yes}" below.
-  permission_change_issue_author: Change issue author

config/locales/bs.yml

@@ -1491,4 +1491,3 @@ bs:
     all references to them. This cannot be undone. Often, locking users instead of deleting
     them is the better solution.
   text_users_bulk_destroy_confirm: To confirm, please enter "%{yes}" below.
-  permission_change_issue_author: Change issue author

config/locales/ca.yml

@@ -1468,4 +1468,3 @@ ca:
     all references to them. This cannot be undone. Often, locking users instead of deleting
     them is the better solution.
   text_users_bulk_destroy_confirm: To confirm, please enter "%{yes}" below.
-  permission_change_issue_author: Change issue author

config/locales/cs.yml

@@ -1461,4 +1461,3 @@ cs:
     all references to them. This cannot be undone. Often, locking users instead of deleting
     them is the better solution.
   text_users_bulk_destroy_confirm: To confirm, please enter "%{yes}" below.
-  permission_change_issue_author: Change issue author

config/locales/da.yml

@@ -1495,4 +1495,3 @@ da:
     all references to them. This cannot be undone. Often, locking users instead of deleting
     them is the better solution.
   text_users_bulk_destroy_confirm: To confirm, please enter "%{yes}" below.
-  permission_change_issue_author: Change issue author