Fix that binmode specified twice (#35539, #35720).

vividtone · vividtone · commit 1578c7207bcd · 2021-08-18T02:34:46.000Z
Patch by Pavel Rosický. git-svn-id: http://svn.redmine.org/redmine/trunk@21193 e93f8b46-1217-0410-a6f0-8f06a7374b81
diff --git a/app/models/attachment.rb b/app/models/attachment.rb
@@ -571,7 +571,7 @@ def create_diskfile(filename, directory=nil, &block)
         name = "#{timestamp}_#{ascii}"
         File.open(
           File.join(path, name),
-          flags: File::CREAT | File::EXCL | File::BINARY | File::WRONLY,
+          flags: File::CREAT | File::EXCL | File::WRONLY,
           binmode: true,
           &block
         )

Original file line number	Diff line number	Diff line change
`@@ -571,7 +571,7 @@ def create_diskfile(filename, directory=nil, &block)`
`571`	`571`	`name = "#{timestamp}_#{ascii}"`
`572`	`572`	`File.open(`
`573`	`573`	`File.join(path, name),`
`574`		`- flags: File::CREAT \| File::EXCL \| File::BINARY \| File::WRONLY,`
	`574`	`+ flags: File::CREAT \| File::EXCL \| File::WRONLY,`
`575`	`575`	`binmode: true,`
`576`	`576`	`&block`
`577`	`577`	`)`